Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nmi_bsod_catch: fix a bug on win10.i386 #3764

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

leidwang
Copy link
Contributor

@leidwang leidwang commented Jul 4, 2023

windbg install path is different between x64 and i386, so update the configuration file to fix the error.

ID:2218864

@leidwang
Copy link
Contributor Author

leidwang commented Jul 4, 2023

@menli820 Could you please help to review this patch?Thanks!

windbg install path is different between x64 and i386,
so update the configuration file to fix the error.

Signed-off-by: Leidong Wang <[email protected]>
@menli820
Copy link
Contributor

menli820 commented Jul 4, 2023

LGTM, thanks!

(01/10) repeat1.Host_RHEL.m9.u3.qcow2.virtio_blk.up.virtio_net.Guest.Win10.i386.io-github-autotest-qemu.nmi_bsod_catch.q35: STARTED
(01/10) repeat1.Host_RHEL.m9.u3.qcow2.virtio_blk.up.virtio_net.Guest.Win10.i386.io-github-autotest-qemu.nmi_bsod_catch.q35: PASS (304.24 s)
(02/10) repeat2.Host_RHEL.m9.u3.qcow2.virtio_blk.up.virtio_net.Guest.Win10.i386.io-github-autotest-qemu.nmi_bsod_catch.q35: STARTED
(02/10) repeat2.Host_RHEL.m9.u3.qcow2.virtio_blk.up.virtio_net.Guest.Win10.i386.io-github-autotest-qemu.nmi_bsod_catch.q35: PASS (303.73 s

@leidwang
Copy link
Contributor Author

@peixiu Could you help to review this patch?

@peixiu
Copy link
Contributor

peixiu commented Jul 21, 2023

python ConfigTest.py --testcase=nmi_bsod_catch --guestname=Win10 --platform=i386 --firmware=default_bios --clone=yes

(1/2) Host_RHEL.m9.u3.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.i386.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: STARTED
(1/2) Host_RHEL.m9.u3.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.i386.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: PASS (708.71 s)
(2/2) Host_RHEL.m9.u3.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.i386.io-github-autotest-qemu.nmi_bsod_catch.q35: STARTED
(2/2) Host_RHEL.m9.u3.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.i386.io-github-autotest-qemu.nmi_bsod_catch.q35: PASS (508.81 s)

LGTM~
Acked-by: Peixiu Hou [email protected]

@leidwang
Copy link
Contributor Author

Hi @vivianQizhu Could you help to review this patch?Thanks

@vivianQizhu
Copy link
Contributor

This is okay but I would prefer have a uniformed params for the directory 'Program Files (x86)', let's have the hotfix first and another patch for the universal changes later.

@vivianQizhu vivianQizhu merged commit fb68299 into autotest:master Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants