-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nmi_bsod_catch: fix a bug on win10.i386 #3764
Conversation
@menli820 Could you please help to review this patch?Thanks! |
windbg install path is different between x64 and i386, so update the configuration file to fix the error. Signed-off-by: Leidong Wang <[email protected]>
LGTM, thanks! (01/10) repeat1.Host_RHEL.m9.u3.qcow2.virtio_blk.up.virtio_net.Guest.Win10.i386.io-github-autotest-qemu.nmi_bsod_catch.q35: STARTED |
@peixiu Could you help to review this patch? |
python ConfigTest.py --testcase=nmi_bsod_catch --guestname=Win10 --platform=i386 --firmware=default_bios --clone=yes (1/2) Host_RHEL.m9.u3.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.i386.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: STARTED LGTM~ |
Hi @vivianQizhu Could you help to review this patch?Thanks |
This is okay but I would prefer have a uniformed params for the directory 'Program Files (x86)', let's have the hotfix first and another patch for the universal changes later. |
windbg install path is different between x64 and i386, so update the configuration file to fix the error.
ID:2218864