Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virtio_port_hotplug.hotplug_port_pci: No free matching bus error #3769

Merged
merged 1 commit into from
Aug 17, 2023
Merged

virtio_port_hotplug.hotplug_port_pci: No free matching bus error #3769

merged 1 commit into from
Aug 17, 2023

Conversation

6-dehan
Copy link
Contributor

@6-dehan 6-dehan commented Jul 5, 2023 •
edited by yanan-fu
Loading

Because the hotplug logic did not show up the correct place,
cause this kind of problem. Change the strategy of hotplugging pci

ID: 1114
Signed-off-by: demeng [email protected]

@6-dehan 6-dehan marked this pull request as draft July 5, 2023 07:53
@6-dehan 6-dehan force-pushed the KVMAUTOMA-1114_vioser_memory_leak branch 3 times, most recently from 4e479ae to 261ced8 Compare July 6, 2023 09:38
@6-dehan 6-dehan force-pushed the KVMAUTOMA-1114_vioser_memory_leak branch from 261ced8 to 13dde2a Compare July 14, 2023 08:05
@6-dehan
Copy link
Contributor Author

6-dehan commented Jul 24, 2023 •
edited
Loading

042-Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.x86_64.io-github-autotest-qemu.virtio_serial_file_transfer.unix_socket.max_ports.q35 | PASS
059-Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.x86_64.io-github-autotest-qemu.virtio_port_hotplug.hotplug_port_pci.q35 | PASS
046-Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.vioser_in_use.with_vcpu_hotplug.transfer_both.q35 |PASS

other test results were passed as well. @vivianQizhu @leidwang could you please have a check when you're free?

@6-dehan 6-dehan marked this pull request as ready for review July 24, 2023 02:21
leidwang
leidwang reviewed Jul 27, 2023
View reviewed changes
qemu/tests/cfg/virtio_port_hotplug.cfg Outdated Show resolved Hide resolved
qemu/tests/virtio_serial_hotplug_port_pci.py Outdated Show resolved Hide resolved
@6-dehan 6-dehan force-pushed the KVMAUTOMA-1114_vioser_memory_leak branch 2 times, most recently from c68e58d to f3844d8 Compare August 15, 2023 08:48
@yanan-fu
Copy link
Contributor

I am ok with the change for virtio_serial_hotplug_port_pci.

However, i do not understand the reason for other changes.
Could you please explain the logic details in the commit info ?

  1. virtio_serial_file_transfer_max_ports: what's the reason of removing memory leak check ?
  2. vioser_in_use: what's the reason of deferring the memory leak check step

@6-dehan
Copy link
Contributor Author

6-dehan commented Aug 16, 2023

I am ok with the change for virtio_serial_hotplug_port_pci.

However, i do not understand the reason for other changes. Could you please explain the logic details in the commit info ?

  1. virtio_serial_file_transfer_max_ports: what's the reason of removing memory leak check ?
  2. vioser_in_use: what's the reason of deferring the memory leak check step

it's really strange, you know I could hit definite issues about these two cases at that time, but for now, I can't hit them anymore. just 'virtio_port_hotplug.hotplug_port_pci' was still there. alright, let me update patch right now.

@6-dehan 6-dehan force-pushed the KVMAUTOMA-1114_vioser_memory_leak branch from f3844d8 to 334b425 Compare August 16, 2023 15:16
@6-dehan
Copy link
Contributor Author

6-dehan commented Aug 16, 2023

other two cases results:
(1/6) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.vioser_in_use.with_vcpu_hotplug.transfer_both.q35: PASS (123.39 s)
(2/6) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.virtio_serial_file_transfer.unix_socket.max_ports.q35: STARTED
(2/6) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.virtio_serial_file_transfer.unix_socket.max_ports.q35: PASS (397.48 s)
(3/6) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.vioser_in_use.with_vcpu_hotplug.transfer_both.q35: STARTED
(3/6) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.vioser_in_use.with_vcpu_hotplug.transfer_both.q35: PASS (195.43 s)
(4/6) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.virtio_serial_file_transfer.unix_socket.max_ports.q35: STARTED
(4/6) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.virtio_serial_file_transfer.unix_socket.max_ports.q35: PASS (378.67 s)
(5/6) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.vioser_in_use.with_vcpu_hotplug.transfer_both.q35: STARTED
(5/6) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.vioser_in_use.with_vcpu_hotplug.transfer_both.q35: PASS (121.54 s)
(6/6) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.virtio_serial_file_transfer.unix_socket.max_ports.q35: STARTED
(6/6) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.virtio_serial_file_transfer.unix_socket.max_ports.q35: PASS (400.16 s)

@6-dehan 6-dehan force-pushed the KVMAUTOMA-1114_vioser_memory_leak branch from 334b425 to 1985507 Compare August 16, 2023 15:24
@yanan-fu
Copy link
Contributor

Ok, if this patch is only focus on the problem with virtio_serial_hotplug_port_pci.py for duplicate hotplug, could you please update the commit info, patch title and so on . thanks!

@6-dehan
virtio_port_hotplug.hotplug_port_pci: No free matching bus error
13ddae0 
Because the hotplug logic did not show up the correct place,
cause this kind of problem. Change the strategy of hotplugging pci

Signed-off-by: demeng <[email protected]>
@6-dehan 6-dehan force-pushed the KVMAUTOMA-1114_vioser_memory_leak branch from 1985507 to 13ddae0 Compare August 17, 2023 03:19
@6-dehan
Copy link
Contributor Author

6-dehan commented Aug 17, 2023

the final test result:
(1/3) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.virtio_port_hotplug.hotplug_port_pci.q35: STARTED
(1/3) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.virtio_port_hotplug.hotplug_port_pci.q35:PASS (120.60 s)
(2/3) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.virtio_port_hotplug.hotplug_port_pci.q35: STARTED
(2/3) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.virtio_port_hotplug.hotplug_port_pci.q35: PASS (117.84 s)
(3/3) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.virtio_port_hotplug.hotplug_port_pci.q35: STARTED
(3/3) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.virtio_port_hotplug.hotplug_port_pci.q35: PASS (119.88 s)
RESULTS : PASS 3 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML : /home/kar/workspace/job-results/job-2023-08-16T23.23-8e8e9dd/results.html
JOB TIME : 360.25 s

@yanan-fu
Copy link
Contributor

@6-dehan Patch title please ~ thanks!

@6-dehan 6-dehan changed the title vioser_in_use.py: change logic of 'memory leak check' location virtio_port_hotplug.hotplug_port_pci: No free matching bus error Aug 17, 2023
@6-dehan
Copy link
Contributor Author

6-dehan commented Aug 17, 2023

@6-dehan Patch title please ~ thanks!

done with it. thanks so much.

yanan-fu
yanan-fu approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@yanan-fu yanan-fu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@yanan-fu yanan-fu merged commit 4e6a747 into autotest:master Aug 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leidwang leidwang leidwang left review comments

@yanan-fu yanan-fu yanan-fu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@6-dehan @yanan-fu @leidwang