Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virtiofs_supp_for_fs: add a new test case #3784

Merged
merged 1 commit into from
Dec 11, 2023
Merged

virtiofs_supp_for_fs: add a new test case #3784

merged 1 commit into from
Dec 11, 2023

Conversation

nickzhq
Copy link
Contributor

@nickzhq nickzhq commented Jul 25, 2023 •
edited
Loading

id: 1478

@nickzhq nickzhq force-pushed the Virtiofs_support_for_file_system_2218413 branch from 5780533 to f38204b Compare July 25, 2023 05:44
@nickzhq
Copy link
Contributor Author

nickzhq commented Jul 25, 2023

(1/2) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2016.x86_64.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: STARTED
(1/2) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2016.x86_64.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: PASS (913.52 s)
(2/2) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2016.x86_64.io-github-autotest-qemu.virtiofs_supp_for_fs.q35: STARTED
(2/2) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2016.x86_64.io-github-autotest-qemu.virtiofs_supp_for_fs.q35: PASS (120.90 s)
RESULTS : PASS 2 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

@nickzhq
Copy link
Contributor Author

nickzhq commented Jul 25, 2023

@xiagao @zhencliu @YongxueHong Please take a look, thanks!

@nickzhq
Copy link
Contributor Author

nickzhq commented Aug 9, 2023

@xiagao @zhencliu @YongxueHong Please take a look, thanks!

@nickzhq
Copy link
Contributor Author

nickzhq commented Aug 21, 2023

@xiagao @zhencliu @YongxueHong Please take a look, thanks!

xiagao
xiagao reviewed Aug 21, 2023
View reviewed changes
qemu/tests/cfg/virtiofs_supp_for_fs.cfg Outdated Show resolved Hide resolved
qemu/tests/cfg/virtiofs_supp_for_fs.cfg Outdated Show resolved Hide resolved
qemu/tests/cfg/virtiofs_supp_for_fs.cfg Outdated Show resolved Hide resolved
qemu/tests/cfg/virtiofs_supp_for_fs.cfg Outdated Show resolved Hide resolved
qemu/tests/virtiofs_supp_for_fs.py Outdated Show resolved Hide resolved
@nickzhq nickzhq force-pushed the Virtiofs_support_for_file_system_2218413 branch 2 times, most recently from 1a70ab2 to 6894057 Compare August 21, 2023 07:02
YongxueHong
YongxueHong reviewed Aug 21, 2023
View reviewed changes
qemu/tests/cfg/virtio_fs_support_win_fs.cfg Outdated Show resolved Hide resolved
qemu/tests/virtio_fs_support_win_fs.py Outdated Show resolved Hide resolved
qemu/tests/virtio_fs_support_win_fs.py Outdated Show resolved Hide resolved
qemu/tests/virtio_fs_support_win_fs.py Outdated Show resolved Hide resolved
qemu/tests/cfg/virtio_fs_support_win_fs.cfg Outdated Show resolved Hide resolved
@nickzhq nickzhq force-pushed the Virtiofs_support_for_file_system_2218413 branch from 6894057 to c67dccb Compare August 24, 2023 06:57
@nickzhq
Copy link
Contributor Author

nickzhq commented Aug 24, 2023

@xiagao @YongxueHong Please take a review, thanks!

@nickzhq nickzhq force-pushed the Virtiofs_support_for_file_system_2218413 branch from c67dccb to 3740cff Compare August 29, 2023 08:21
@nickzhq
Copy link
Contributor Author

nickzhq commented Aug 29, 2023

@YongxueHong Please take a review, thanks!

YongxueHong
YongxueHong previously approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@YongxueHong YongxueHong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nickzhq nickzhq force-pushed the Virtiofs_support_for_file_system_2218413 branch from 3740cff to 33ad81c Compare August 30, 2023 03:23
@nickzhq
Copy link
Contributor Author

nickzhq commented Aug 30, 2023

@xiagao Please take a review. Thanks!
The multi-arch has been removed.

@zhencliu
Copy link
Contributor

LGTM

@xiagao
Copy link
Contributor

xiagao commented Aug 30, 2023

Seems that the install cmd doesn't work. I ran the virtio-win iso which would make this test fail, but actually, it passed.
And I try it by manual, it indeed failed.

python3 ConfigTest.py --testcase=virtio_fs_support_win_fs --guestname=Win10 --customsparams="cdrom_virtio = isos/windows/virtio-win-prewhql-0.1-236.iso" --clone=no

(1/1) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.x86_64.io-github-autotest-qemu.virtio_fs_support_win_fs.q35: STARTED
(1/1) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.x86_64.io-github-autotest-qemu.virtio_fs_support_win_fs.q35: PASS (169.90 s)
(1/1) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.x86_64.io-github-autotest-qemu.virtio_fs_support_win_fs.q35: STARTED
(1/1) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.x86_64.io-github-autotest-qemu.virtio_fs_support_win_fs.q35: PASS (169.90 s)

@PaulYuuu PaulYuuu mentioned this pull request Aug 31, 2023
Merged
@nickzhq nickzhq force-pushed the Virtiofs_support_for_file_system_2218413 branch 2 times, most recently from 977dcd0 to 5b1098c Compare September 1, 2023 02:51
@nickzhq
Copy link
Contributor Author

nickzhq commented Sep 1, 2023

@xiagao Please take a review, thanks!

@xiagao
Copy link
Contributor

xiagao commented Sep 1, 2023

@xiagao Please take a review, thanks!

And the issue I mentioned above, we can talk personally,could you check your google chat?

@nickzhq nickzhq force-pushed the Virtiofs_support_for_file_system_2218413 branch 2 times, most recently from efe837b to 851babb Compare September 4, 2023 02:34
@nickzhq
Copy link
Contributor Author

nickzhq commented Sep 18, 2023

The case is NOT able to be found a valid automation solution.
Abandon.

@xiagao
Copy link
Contributor

xiagao commented Nov 29, 2023

ACK.

@nickzhq
Copy link
Contributor Author

nickzhq commented Nov 29, 2023

@YongxueHong @zhencliu Please take a look, thanks!

@nickzhq nickzhq force-pushed the Virtiofs_support_for_file_system_2218413 branch from 810ade0 to 19f5596 Compare November 29, 2023 09:03
YongxueHong
YongxueHong previously approved these changes Nov 29, 2023
View reviewed changes
@nickzhq nickzhq force-pushed the Virtiofs_support_for_file_system_2218413 branch from 19f5596 to a72525f Compare November 29, 2023 09:13
@nickzhq nickzhq force-pushed the Virtiofs_support_for_file_system_2218413 branch 2 times, most recently from ad4acc3 to 7f6e0f2 Compare November 30, 2023 02:45
@xiagao
Copy link
Contributor

xiagao commented Nov 30, 2023

Win10.i386.io-github-autotest-qemu.virtio_fs_support_win_fs.q35: PASS (624.74 s)

@nickzhq
Copy link
Contributor Author

nickzhq commented Dec 1, 2023

@YongxueHong Please take a look, thanks!

YongxueHong
YongxueHong previously approved these changes Dec 5, 2023
View reviewed changes
@nickzhq nickzhq force-pushed the Virtiofs_support_for_file_system_2218413 branch from 7f6e0f2 to 26e41e8 Compare December 5, 2023 02:52
zhencliu
zhencliu previously approved these changes Dec 5, 2023
View reviewed changes
YongxueHong
YongxueHong previously approved these changes Dec 5, 2023
View reviewed changes
@nickzhq nickzhq dismissed stale reviews from YongxueHong and zhencliu via 77eb566 December 5, 2023 04:51
@nickzhq nickzhq force-pushed the Virtiofs_support_for_file_system_2218413 branch 2 times, most recently from 77eb566 to 7ae8939 Compare December 5, 2023 04:59
@fbq815
Copy link
Contributor

fbq815 commented Dec 7, 2023

double confirm with @xiagao, this is a Windows only test case, will not trigger on s390x.
@YongxueHong please help me cancel the review request
@nickzhq please remove s390x related change the comment I wrote on Aug 30 is only request for the new method of mem-backend, could still follow the form of it.

@nickzhq nickzhq force-pushed the Virtiofs_support_for_file_system_2218413 branch from 7ae8939 to f6b9427 Compare December 8, 2023 03:15
@nickzhq
Copy link
Contributor Author

nickzhq commented Dec 8, 2023

@zhencliu @xiagao @YongxueHong Please take a review, thanks!
The case does NOT support the 390 platform, restore to the previous version.

@YongxueHong YongxueHong merged commit 0e868df into autotest:master Dec 11, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhenyzha zhenyzha zhenyzha left review comments

@zhencliu zhencliu zhencliu approved these changes

@YongxueHong YongxueHong YongxueHong approved these changes

@xiagao xiagao xiagao approved these changes

@fbq815 fbq815 Awaiting requested review from fbq815

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nickzhq @zhencliu @xiagao @fbq815 @YongxueHong @zhenyzha