Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qemu_guest_agent: add checkpoints for 'NVMe' type of disk #3809

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

qemu_guest_agent: add checkpoints for 'NVMe' type of disk #3809

wants to merge 1 commit into from

Conversation

6-dehan
Copy link
Contributor

@6-dehan 6-dehan commented Aug 29, 2023 •
edited
Loading

Add two checkpoints for qga command 'guest-get-disks' to get disk info:

  1. 'smart' parameter for linux and 'bus-type' check
  2. 'bus-type' for windows.

ID: 1440
Signed-off-by: demeng [email protected]

@6-dehan
Copy link
Contributor Author

6-dehan commented Aug 29, 2023 •
edited
Loading

Depends on:
#3808

@6-dehan 6-dehan force-pushed the 2176372-nvme-smart-linux branch 3 times, most recently from 0196ecf to 304ea56 Compare August 29, 2023 08:06
@6-dehan
Copy link
Contributor Author

6-dehan commented Aug 29, 2023

@vivianQizhu @PaulYuuu could you please help to review it?
(1/2) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.check_get_disks.q35: STARTED
(1/2) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.3.0.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.check_get_disks.q35: PASS (131.02 s)
(2/2) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.check_get_disks.q35: STARTED
(2/2) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.check_get_disks.q35: PASS (137.87 s)

@6-dehan
Copy link
Contributor Author

6-dehan commented Aug 30, 2023

@MiriamDeng @fbq815 @BohdanMar does it affect your scenario? if so, please help to review it.

@fbq815
Copy link
Contributor

fbq815 commented Sep 18, 2023

LGTM, but we don't really have NVMe device to check it, let's keep s390x with this test case. (The attempt issue would be different device path)

@MiriamDeng
Copy link
Contributor

There is no support in ppc64le for NVME emulation in KVM, also cc @maxujun Thanks.

@BohdanMar
Copy link
Contributor

Also doesn't support the same way on the aarch64 platform.

@6-dehan 6-dehan force-pushed the 2176372-nvme-smart-linux branch 3 times, most recently from 9310ee1 to bd26823 Compare October 30, 2023 14:13
@6-dehan 6-dehan force-pushed the 2176372-nvme-smart-linux branch 2 times, most recently from bc29100 to 12ad793 Compare November 13, 2023 02:43
@6-dehan
qemu_guest_agent: add checkpoints for 'NVMe' type of disk
1aecb34 
Add two checkpoints for qga command 'guest-get-disks' to
get disk info:
1. 'smart' parameter for linux and 'bus-type' check
2. 'bus-type' for windows.

Signed-off-by: demeng <[email protected]>
@PaulYuuu PaulYuuu marked this pull request as draft December 6, 2023 07:13
@PaulYuuu
Copy link
Contributor

PaulYuuu commented Dec 6, 2023

Draft the patch as the dependent one is still waiting for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivianQizhu vivianQizhu vivianQizhu left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@6-dehan @fbq815 @MiriamDeng @BohdanMar @PaulYuuu @vivianQizhu