Configure outer VLAN MTU to 1504 for e1000e device on qemu-8.1 #3883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanglei-rh
force-pushed
the
KVMAUTOMA-1556
branch
2 times, most recently
from
a1ecd6d
to
db1e801
Compare
|
Test Pass: |
|
Hello @PaulYuuu Could you please help me review this patch? Thanks in advance. |
PaulYuuu
reviewed
Nov 28, 2023
Since there is commit fixed the packet size check and made it more strict about the packet size,based on this commit QEMU handled the ethernet FCS packets which is 4-byte long, so the maximum size should be subtracted 4.This surfaced a problem in the test case that the guest sends a packet larger than 1522 bytes without setting the LPE flag.A QinQ packet has a 22-byte header, the default MTU in VLAN is 1500, and an ethernet FCS is 4-byte long as I described earlier so the maximum packet size will be 22 + 1500 + 4 = 1526, which is 4-byte larger than 1522 bytes.So the fix is make the outer VLAN MTU greater to let the driver set the LPE flag. Signed-off-by: Lei Yang <[email protected]>
yanglei-rh
force-pushed
the
KVMAUTOMA-1556
branch
from
db1e801
to
32c7dd5
Compare
PaulYuuu
approved these changes
Nov 29, 2023
|
Test Pass: |
|
This only affects e1000e device, I will merge it since x86 test is passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there is commit fixed the packet size check and made it more strict about the packet size,based on this commit QEMU handled the ethernet FCS packets which is 4-byte long, so the maximum size should be subtracted 4.This surfaced a problem in the test case that the guest sends a packet larger than 1522 bytes without setting the LPE flag.A QinQ packet has a 22-byte header, the default MTU in VLAN is 1500, and an ethernet FCS is 4-byte long as I described earlier so the maximum packet size will be 22 + 1500 + 4 = 1526, which is 4-byte larger than 1522 bytes.So the fix is make the outer VLAN MTU greater to let the driver set the LPE flag.
ID: 1556
Signed-off-by: Lei Yang [email protected]