Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qemu_guest_agent: Add ssh-key injection support for windows #4129

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

qemu_guest_agent: Add ssh-key injection support for windows #4129

wants to merge 1 commit into from

Conversation

6-dehan
Copy link
Contributor

@6-dehan 6-dehan commented Aug 6, 2024

Add public ssh-key injection support for windows. Linux had been supported already.

ID: 2587
Signed-off-by: Dehan Meng [email protected]

@6-dehan 6-dehan marked this pull request as draft August 6, 2024 10:48
@6-dehan 6-dehan force-pushed the KVMAUTOMA-2587-support-ssh-windows branch from 0e0517d to 54c8983 Compare August 7, 2024 05:00
@6-dehan 6-dehan force-pushed the KVMAUTOMA-2587-support-ssh-windows branch 2 times, most recently from ca6b48f to 45d95be Compare August 22, 2024 02:45
@6-dehan 6-dehan marked this pull request as ready for review September 13, 2024 02:29
@6-dehan 6-dehan force-pushed the KVMAUTOMA-2587-support-ssh-windows branch from 45d95be to 227c663 Compare September 13, 2024 02:29
@6-dehan
Copy link
Contributor Author

6-dehan commented Sep 13, 2024

@leidwang could you please help review it when you're free? thanks
(01/10) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.gagent_ssh_public_key_injection.administrator.q35: STARTED
(01/10) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.gagent_ssh_public_key_injection.administrator.q35: PASS (155.20 s)
(02/10) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.gagent_ssh_public_key_injection.non_admin_user.q35: STARTED
(02/10) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.gagent_ssh_public_key_injection.non_admin_user.q35: PASS (163.27 s)
(03/10) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2016.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.gagent_ssh_public_key_injection.administrator.q35: STARTED
(03/10) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2016.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.gagent_ssh_public_key_injection.administrator.q35: PASS (99.09 s)
(04/10) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2016.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.gagent_ssh_public_key_injection.non_admin_user.q35: STARTED
(04/10) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2016.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.gagent_ssh_public_key_injection.non_admin_user.q35: PASS (177.58 s)
(05/10) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.gagent_ssh_public_key_injection.administrator.q35: STARTED
(05/10) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.gagent_ssh_public_key_injection.administrator.q35: PASS (123.14 s)
(06/10) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.gagent_ssh_public_key_injection.non_admin_user.q35: STARTED
(06/10) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.gagent_ssh_public_key_injection.non_admin_user.q35: PASS (134.06 s)
(07/10) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.gagent_ssh_public_key_injection.administrator.q35: STARTED
(07/10) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.gagent_ssh_public_key_injection.administrator.q35: PASS (134.39 s)
(08/10) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.gagent_ssh_public_key_injection.non_admin_user.q35: STARTED
(08/10) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.gagent_ssh_public_key_injection.non_admin_user.q35: PASS (141.86 s)
(09/10) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2025.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.gagent_ssh_public_key_injection.administrator.q35: STARTED
(09/10) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2025.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.gagent_ssh_public_key_injection.administrator.q35: PASS (98.81 s)
(10/10) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2025.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.gagent_ssh_public_key_injection.non_admin_user.q35: STARTED
(10/10) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2025.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.gagent_ssh_public_key_injection.non_admin_user.q35: PASS (102.32 s)

@6-dehan 6-dehan force-pushed the KVMAUTOMA-2587-support-ssh-windows branch from 227c663 to 153464c Compare September 27, 2024 02:02
@6-dehan
Copy link
Contributor Author

6-dehan commented Sep 27, 2024

@fbq815 @MiriamDeng @BohdanMar I'm not sure if you guys test Windows for qga or not, if not, it won't require any test, just please be aware of this support (send ssh-key to Windows/Linux via qga could be a non-network-option.)

@fbq815
Copy link
Contributor

fbq815 commented Sep 27, 2024

no windows guest is tested on s390x

@MiriamDeng
Copy link
Contributor

Windows is not supported on ppc side, please ignore ppc.

leidwang
leidwang approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@leidwang leidwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MiriamDeng
Copy link
Contributor

Windows is not supported on ppc side. Thanks.

@6-dehan
Copy link
Contributor Author

6-dehan commented Oct 16, 2024

Hi @vivianQizhu , Could you please help to review and merge this patch?

@6-dehan 6-dehan force-pushed the KVMAUTOMA-2587-support-ssh-windows branch 2 times, most recently from 6128af5 to 4fe12b3 Compare October 18, 2024 08:26
@6-dehan
qemu_guest_agent: Add ssh-key injection support for windows
4fe4cdc 
Add public ssh-key injection support for windows. Linux had been
supported already.
Add script Install_config_OpenSSH.ps1 to prepare OPenSSH.

Signed-off-by: Dehan Meng <[email protected]>
@6-dehan 6-dehan force-pushed the KVMAUTOMA-2587-support-ssh-windows branch from 4fe12b3 to 4fe4cdc Compare October 21, 2024 04:41
leidwang
leidwang reviewed Oct 23, 2024
View reviewed changes
qemu/tests/cfg/qemu_guest_agent.cfg
- non_admin_user:
only Windows
guest_user = "nonadminuser"
guest_user_passwd = "Redhat."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should move this line to internal too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nonadminuser for no any real meaning. So I think it's okay to keep it here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed in slack, we should not add any password to github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leidwang leidwang leidwang approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@6-dehan @fbq815 @MiriamDeng @leidwang