Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virtio_win_installer: update the installer script #4137

Merged
merged 1 commit into from
Aug 30, 2024
Merged

virtio_win_installer: update the installer script #4137

merged 1 commit into from
Aug 30, 2024

Conversation

xiagao
Copy link
Contributor

@xiagao xiagao commented Aug 20, 2024

Since virtio-win 1.9.41 version, there is no restart requirement when install and uninstall the installer, while repair still has.
ID: 2785

@xiagao xiagao force-pushed the bz2785-installer-no-reboot branch 2 times, most recently from ad526c1 to fb8abab Compare August 21, 2024 08:51
@xiagao
Copy link
Contributor Author

xiagao commented Aug 28, 2024

@leidwang Could you help review?

@xiagao
Copy link
Contributor Author

xiagao commented Aug 28, 2024

(03/32) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.win_virtio_driver_install_by_installer.driver_install.single_driver.with_viostor.q35: STARTED
(03/32) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.win_virtio_driver_install_by_installer.driver_install.single_driver.with_viostor.q35: PASS (380.94 s)
(13/32) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.win_virtio_driver_install_by_installer.driver_uninstall.q35: FAIL: ['VirtIO RNG Device', 'VirtIO Serial Driver', 'VirtIO Balloon Driver', 'QEMU PVPanic Device', 'VirtIO Input Driver', 'Red Hat VirtIO Ethernet Adapter', 'VirtIO FS Device', 'QEMU FwCfg Device'] uninstall failed (558.78 s)

@xiagao
virtio_win_installer: update the installer script
c4f31cc 
Since virtio-win 1.9.41 version, there is no restart
requirement when install and uninstall the installer.
while repair still has.

Signed-off-by: Xiaoling Gao <[email protected]>
leidwang
leidwang approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@leidwang leidwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xiagao
Copy link
Contributor Author

xiagao commented Aug 30, 2024

@vivianQizhu Could you help review this patch? Thanks.

@vivianQizhu vivianQizhu merged commit cde30ca into autotest:master Aug 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivianQizhu vivianQizhu vivianQizhu approved these changes

@leidwang leidwang leidwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiagao @vivianQizhu @leidwang