passt file transfer tests via tcp/udp #4150
Open
+145
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanglei-rh
force-pushed
the
2853
branch
4 times, most recently
from
b0b1fda
to
c6c2d1f
Compare
|
Hi @PaulYuuu Could you please help me review this patch? It can test pass on my side, thanks in advance. |
PaulYuuu
reviewed
Sep 10, 2024
yanglei-rh
force-pushed
the
2853
branch
2 times, most recently
from
5c1dadf
to
7944bac
Compare
PaulYuuu
reviewed
Sep 18, 2024
Add a new case to support passt file transfer test via tcp/udp Signed-off-by: Lei Yang <[email protected]>
|
Hello @PaulYuuu Could you please help review it again? I have update it based on your last times comment. And the corrent code can test pass on my side. Thanks in advance. |
PaulYuuu
reviewed
Sep 27, 2024
| test.log.info) | ||
| if dst_md5 != src_md5: | ||
| test.fail("File changed after transfer host -> %s" % vm.name) | ||
| host2guest_port += 1 |
There was a problem hiding this comment.
Both host2guest_port and guest2guest_port should from vim.virtnet, not simple calculations, if the vm ports are 1001 and 1003, the current not work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new case to support passt file transfer test via tcp/udp
ID:2853
Signed-off-by: Lei Yang [email protected]