Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qemu_guest_agent: Report message changed for api qga-freeze #4154

Merged

Conversation

6-dehan
Copy link
Contributor

@6-dehan 6-dehan commented Sep 11, 2024

The fsfreeze commands are already written to report an error if vss_init() fails. Reporting a more specific error message is more helpful than a generic "command is disabled" message

ID: 2868
Signed-off-by: demeng [email protected]

The fsfreeze commands are already written to report an error if
vss_init() fails. Reporting a more specific error message is more
helpful than a generic "command is disabled" message

Signed-off-by: Dehan Meng <[email protected]>
@6-dehan
Copy link
Contributor Author

6-dehan commented Sep 13, 2024

@leidwang Could you pls help to review this one when you're free?
(1/2) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.check_freeze_frozen.q35: PASS (140.16 s)
(2/2) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.check_freeze_frozen.q35: PASS (49.40 s)

Copy link
Contributor

@leidwang leidwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@6-dehan
Copy link
Contributor Author

6-dehan commented Oct 9, 2024

Hi @vivianQizhu , Could you please help to review and merge it when you're free? thanks

@vivianQizhu vivianQizhu merged commit e512038 into autotest:master Oct 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants