Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qemu_guest_agent: fix installer installation failed issue #4157

Merged
merged 1 commit into from
Oct 18, 2024
Merged

qemu_guest_agent: fix installer installation failed issue #4157

merged 1 commit into from
Oct 18, 2024

Conversation

xiagao
Copy link
Contributor

@xiagao xiagao commented Sep 12, 2024 •
edited
Loading

Installation of installer would quit because virtio-net was uninstalled and re-installed in the process which cause the session was lost, and then autoit process would quit. Then using other network type instead of virtio-net would work.

ID: 2811

@xiagao
Copy link
Contributor Author

xiagao commented Sep 12, 2024

(1/1) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2025.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.gagent_driver_update_via_installer_tool.q35: STARTED
(1/1) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2025.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.gagent_driver_update_via_installer_tool.q35: PASS (619.44 s)

@xiagao
Copy link
Contributor Author

xiagao commented Sep 12, 2024

@leidwang @6-dehan Could you please help review?

@leidwang
Copy link
Contributor

The code LGTM, but there is a typo in the commit message and PR description.

6-dehan
6-dehan approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@6-dehan 6-dehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiagao
Copy link
Contributor Author

xiagao commented Sep 13, 2024

The code LGTM, but there is a typo in the commit message and PR description.
Could you help point it out?

@leidwang
Copy link
Contributor

The code LGTM, but there is a typo in the commit message and PR description.
Could you help point it out?

image

@xiagao
qemu_guest_agent: fix installer installation failed issue
0bb7a0f 
Installation of installer would quit because virtio-net was
uninstalled and re-installed in the process which cause the
session was lost, and then autoit process would quit.
Then using other network type instead of virtio-net would work.

Signed-off-by: Xiaoling Gao <[email protected]>
@xiagao
Copy link
Contributor Author

xiagao commented Sep 13, 2024

The code LGTM, but there is a typo in the commit message and PR description.

Could you

The code LGTM, but there is a typo in the commit message and PR description.
Could you help point it out?

image

@leidwang Updated, thanks.

@xiagao
Copy link
Contributor Author

xiagao commented Sep 25, 2024

@vivianQizhu Could you help review this one? THanks.

@leidwang
Copy link
Contributor

Hi @vivianQizhu Would you please help review this MR when you have time?Thanks.

@vivianQizhu vivianQizhu merged commit ccff6ae into autotest:master Oct 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@6-dehan 6-dehan 6-dehan approved these changes

@leidwang leidwang leidwang approved these changes

@vivianQizhu vivianQizhu vivianQizhu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiagao @leidwang @vivianQizhu @6-dehan