Netkvm: Fix session handling issue during netkvm driver installation #4158
Conversation
heywji
force-pushed
the
fix_ws2016_session
branch
2 times, most recently
from
9655041
to
7622023
Compare
qemu/tests/single_driver_install.py
Outdated
|
|
||
| ext_host = utils_net.get_ip_address_by_interface(ifname="%s" % params.get("netdst")) | ||
| test.log.info("ext_host of netkvm adapte is %s" % ext_host) | ||
| guest_ip = vm.get_address(1) |
There was a problem hiding this comment.
I'm curious how to determine the ip owner? rtl8139 or virtio-net ?
There was a problem hiding this comment.
I use get_address function call to get my IP, and its parameter "1" comes from the "single_driver_install.cfg" file, where it is defined as nic_model_nic2.
There was a problem hiding this comment.
As our discussion, I changed "Index as 1" to "Name as nic2" now. This also works. Please review it when you are free. Thanks in advance.
heywji
force-pushed
the
fix_ws2016_session
branch
5 times, most recently
from
4c4b0d8
to
088ff5f
Compare
|
Test Result: Fully passed on "--category=virtio_win_prewhql_acceptance --guestname=Win2016" |
heywji
force-pushed
the
fix_ws2016_session
branch
3 times, most recently
from
cfcae03
to
217316a
Compare
|
Hi @leidwang, Could you help review it when you have times? Thanks :) |
heywji
force-pushed
the
fix_ws2016_session
branch
from
217316a
to
468a5a2
Compare
heywji
force-pushed
the
fix_ws2016_session
branch
from
468a5a2
to
4acabcd
Compare
|
Hi @lkotek Would you please help review this PR, I guess gating test also include this test case,thanks! |
Ack. Yes, exactly. I am aware of the issue because of the gating stage jobs. Thanks for the fix! I am fine with the changes as the PR was already successfully tested with Win2016 guest. |
|
Hi @vivianQizhu, Could you help review this patch as well, thanks a lot. |
qemu/tests/single_driver_install.py
Outdated
| @@ -172,6 +174,15 @@ def run(test, params, env): | |||
| if not utils_misc.wait_for(lambda: not session.cmd_status(chk_cmd), | |||
| 600, 60, 10): | |||
| test.fail("Failed to install driver '%s'" % driver_name) | |||
| if device_name[0:30] == "Red Hat VirtIO Ethernet Adapte": | |||
There was a problem hiding this comment.
I think there is a typo on the device name.
There was a problem hiding this comment.
@vivianQizhu, That is the name of device_name. It was in effect in our recent test log.
There was a problem hiding this comment.
My bad. I see my mistake. I will fix it.
There was a problem hiding this comment.
I have fixed it. Could you help review it again? Thanks a lot!
heywji
force-pushed
the
fix_ws2016_session
branch
3 times, most recently
from
0292c08
to
293f43d
Compare
heywji
force-pushed
the
fix_ws2016_session
branch
3 times, most recently
from
33b641f
to
bfe157e
Compare
|
Test Result: |
heywji
force-pushed
the
fix_ws2016_session
branch
from
bfe157e
to
246bdc3
Compare
heywji
force-pushed
the
fix_ws2016_session
branch
from
246bdc3
to
7e02e0d
Compare
Installing the netkvm driver on an existing network interface caused session handling issues, leading to test failures. This patch changes the session handling from SSH to the serial session by replacing vm.wait_for_login() with vm.wait_for_serial_login(). It also adds a ping test to verify network connectivity after the driver installation. Signed-off-by: wji <[email protected]>
heywji
force-pushed
the
fix_ws2016_session
branch
from
7e02e0d
to
47078b5
Compare
Installing the netkvm driver on an existing network interface caused session handling issues, leading to test failures. This patch changes the session handling from SSH to the serial session by replacing vm.wait_for_login() with vm.wait_for_serial_login(). It also adds a ping test to verify network connectivity after the driver installation.
ID: 1382
Signed-off-by: wji [email protected]