-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ovmf_check_efi: change sgdisk to parted #4159
Conversation
(1/2) Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.4.x86_64.io-github-autotest-qemu.ovmf_check_efi.q35: PASS (54.63 s) |
@zhencliu, Could you please help review it? Many thanks. |
qemu/tests/cfg/ovmf_check_efi.cfg
Outdated
@@ -2,7 +2,7 @@ | |||
only q35 | |||
only ovmf | |||
type = ovmf_check_efi | |||
check_cmd = "gdisk -l /dev/[vs]da" | |||
check_cmd = "parted -l /dev/[vs]da" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @XueqiangWei , parted -l will list partition layout on all block devices, of course, in your case, only one device is configured, can we remove /dev/[vs]da?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, thanks Zhenchao.
f2a33b2
to
6d33cc0
Compare
Due to the deletion of sgdisk in the latest linux, change sgdisk to parted in this case Signed-off-by: Xueqiang Wei <[email protected]>
6d33cc0
to
498895c
Compare
(1/1) Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.4.0.x86_64.io-github-autotest-qemu.ovmf_check_efi.q35: PASS (60.82 s) |
@zhencliu Could you please help review it again? Many thanks. |
Zhenchao, Many thanks. |
Due to the deletion of sgdisk in the latest linux, change sgdisk to parted in this case
Signed-off-by: Xueqiang Wei [email protected]
ID: 2880