edk2_check_mor: add a new case #4162
Conversation
XueqiangWei
force-pushed
the
edk2_check_mor
branch
from
4226ff5
to
090d2ef
Compare
|
(1/1) Host_RHEL.m9.x.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.x.x86_64.io-github-autotest-qemu.edk2_check_mor.q35: STARTED |
|
@zhencliu, Could you please help review it? Many thanks. |
qemu/tests/edk2_check_mor.py
Outdated
| try: | ||
| find_command(params["cmd_installed"]) | ||
| except CmdNotFoundError as e: | ||
| test.error(e.__str__()) |
There was a problem hiding this comment.
updated, thanks.
| if status: | ||
| test.cancel('Secure boot is not enabled,' | ||
| 'MOR must run under secure mode') | ||
| if not signed: |
There was a problem hiding this comment.
move the if under line 53?
There was a problem hiding this comment.
updated, check whether the guest has been signed after checking secure boot enabled. If the guest is not signed, it should not boot succeed under secure mode. Thanks.
| return True if re.search(sign_keyword, sign_info) else False | ||
|
|
||
| package = params["package_installed"] | ||
| install_status = utils_package.package_install(package) |
There was a problem hiding this comment.
Do we need to uninstall the package post-test?
There was a problem hiding this comment.
No, this package is very small and it contains test scripts, I think it can be kept. Thanks.
(Of course, we can call the function utils_package.package_remove(), but I think we can keep it here.)
check mor enabled under secure mode Signed-off-by: Xueqiang Wei <[email protected]>
XueqiangWei
force-pushed
the
edk2_check_mor
branch
from
090d2ef
to
7fe2b59
Compare
|
(1/1) Host_RHEL.m9.u5.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.5.0.x86_64.io-github-autotest-qemu.edk2_check_mor.q35: PASS (128.93 s) |
|
@zhencliu Could you please help review it again? Many thanks. |
check mor enabled under secure mode
Signed-off-by: Xueqiang Wei [email protected]
ID: 2895