-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maxbytes_negative: Update max-bytes negative cases #4166
base: master
Are you sure you want to change the base?
Conversation
Hi @MiriamDeng @fbq815 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
1. 'max-bytes=0' setting is no longer allowed by the latest QEMU. Error prompt will be generated when 'max-bytes' is set to 0. 2. Update corresponding error info. Signed-off-by: ybduan <[email protected]>
a42cf97
to
6e81891
Compare
Hi @MiriamDeng @fbq815 Could you help review it from your platform? Thanks. |
@ybduan @YongxueHong I've checked the patch is fine, but in my perspective I prefer if we could keep the supports on old versions as well, @PaulYuuu agree with the opinion and maybe we should ask feature owners on all platforms to vote |
Hi @fbq815 |
@ybduan For the arm platform, we have just released GA on rhel.9.4. On the other hand, tp-libvirt will retain support for older versions, so there is no requirement for forward compatibility on the arm platform on the tp-qemu side. |
ID: 2469
Error prompt will be generated when 'max-bytes' is set to 0.