Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxbytes_negative: Update max-bytes negative cases #4166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ybduan
Copy link
Contributor

@ybduan ybduan commented Sep 26, 2024

ID: 2469

  1. 'max-bytes=0' setting is no longer allowed by the latest QEMU.
    Error prompt will be generated when 'max-bytes' is set to 0.
  2. Update corresponding error info.

@YongxueHong
Copy link
Contributor

Hi @MiriamDeng @fbq815
Could you help review it from your platform?
Thanks.

YongxueHong
YongxueHong previously approved these changes Oct 9, 2024
Copy link
Contributor

@YongxueHong YongxueHong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@XueqiangWei
Copy link
Contributor

Hi @MiriamDeng @fbq815 Could you help review it from your platform? Thanks.

@fbq815
Copy link
Contributor

fbq815 commented Oct 25, 2024

@ybduan @YongxueHong I've checked the patch is fine, but in my perspective I prefer if we could keep the supports on old versions as well, @PaulYuuu agree with the opinion and maybe we should ask feature owners on all platforms to vote

@YongxueHong
Copy link
Contributor

@ybduan @YongxueHong I've checked the patch is fine, but in my perspective I prefer if we could keep the supports on old versions as well, @PaulYuuu agree with the opinion and maybe we should ask feature owners on all platforms to vote

Hi @fbq815
Got your point. @ybduan How about your thoughts? Both are okay with me, depending on all the feature owners' considerations.
Thanks.
Hi @ybduan Could you help to invite other platform reviewers with this PR?
Thanks in advance.

@zhenyzha
Copy link
Contributor

@ybduan For the arm platform, we have just released GA on rhel.9.4. On the other hand, tp-libvirt will retain support for older versions, so there is no requirement for forward compatibility on the arm platform on the tp-qemu side.

1. 'max-bytes=0' setting is no longer allowed by the latest QEMU.
Error prompt will be generated when 'max-bytes' is set to 0.
2. Update corresponding error info.

Signed-off-by: ybduan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants