fwcfg: fix wmic query to ensure windbg installation for fwcfg cases #4181
+6
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heywji
force-pushed
the
fix_fwcfg_windbg
branch
2 times, most recently
from
03313b7
to
1b13681
Compare
heywji
changed the title
heywji
force-pushed
the
fix_fwcfg_windbg
branch
2 times, most recently
from
827c3a3
to
ec972ec
Compare
heywji
changed the title
|
Test Result: |
|
@xiagao Could you help review this patch since our windbg tools not problem has been fixed? This is not urgent, thanks for your time :) |
xiagao
reviewed
Oct 21, 2024
provider/win_dump_utils.py
Outdated
| if status == 1: | ||
| time.sleep(30) | ||
| else: | ||
| LOG_JOB.info("windbg tool installation completed") |
There was a problem hiding this comment.
I think the original utils_misc.wait_for() function is better， extending the timeout value could cover your requirement.
There was a problem hiding this comment.
Agree with you. We can only modify the WMIC queries part and keep the current timeout value.
heywji
force-pushed
the
fix_fwcfg_windbg
branch
12 times, most recently
from
7600459
to
48df467
Compare
|
Test Result: |
|
Hi @xiagao, Could you help review this patch again? It has passed for the all guests. |
heywji
force-pushed
the
fix_fwcfg_windbg
branch
from
48df467
to
3b4cce9
Compare
xiagao
reviewed
Nov 1, 2024
qemu/tests/cfg/fwcfg.cfg
Outdated
| @@ -19,21 +19,17 @@ | |||
| image_name_stg = "images/storage" | |||
| remove_image_stg = yes | |||
| no ppc64 ppc64le aarch64 | |||
| chk_windbg_cmd = 'wmic product get name,version | find /i "SDK Debuggers"' | |||
There was a problem hiding this comment.
As WMIC would be deprecated gradually, it is superseded by windows powershell for WMI.
There was a problem hiding this comment.
OK, I will find the replacement command.
There was a problem hiding this comment.
This command line could be a replacement.
Get-WmiObject Win32_Product | Where-Object Name -like "*SDK Debuggers*" | Select Name, Version
3b4cce9
to
9d0bd15
Compare
The issue with WinDbg not being found was caused by incorrect WMIC queries. Signed-off-by: wji <[email protected]>
heywji
force-pushed
the
fix_fwcfg_windbg
branch
from
9d0bd15
to
3830383
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue with WinDbg not being found was caused by incorrect WMIC queries.
ID: 1770
Signed-off-by: wji [email protected]