virtio_fs_nfs_migration: Virtiofs migration testing over NFS #4190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhencliu
force-pushed
the
virtiofs_migration_nfs
branch
8 times, most recently
from
a345b0e to
5ae85f0
Compare
|
Hi @hellohellenmao , would you please review this patch? Testing on RHEL9.3 and Win2022 has passed, thanks. |
|
Hi @zhencliu Thanks. |
zhencliu
force-pushed
the
virtiofs_migration_nfs
branch
3 times, most recently
from
142bc9f to
2b1d493
Compare
|
@zhencliu we use memory-backend-file on s390x when we use memory-backend with virtio-fs, please reference to the usage of avocado-framework/avocado-vt@85915c0 |
xiagao
reviewed
Dec 6, 2024
|
@zhencliu s390x.io-github-autotest-qemu.virtio_fs_nfs_migration.file_handles_mandatory.dio.cache_mode_never.s390-virtio:ERROR: 'NoneType' object has no attribute 'close' (12.06 s) |
win2025 on x86_64 also has this issue. |
hellohellenmao
suggested changes
Jan 17, 2025
zhencliu
force-pushed
the
virtiofs_migration_nfs
branch
3 times, most recently
from
6f8f60b to
1b8661d
Compare
|
hi @hellohellenmao , two virtiofs scenario was added, would you please have a check? Thanks Passed on RHEL9 and Win2025 |
hellohellenmao
suggested changes
Feb 5, 2025
The following testing matrix is covered: cache mode: auto, never, always, metadata writeback: enabled and disabled allow-direct-io enabled and disabled file-handles mandatory and never virtiofs single fs and two fs Note we usually use memory-backend-file on s390x for the virtio-fs testing on RHEL, but for the live migration scenario, we have to use memory-backend-memfd due to RHEL-58831. Signed-off-by: Zhenchao Liu <[email protected]>
A full process name is required for the TASKKILL command, e.g. TASKKILL /F /IM fio.exe /T Signed-off-by: Zhenchao Liu <[email protected]>
zhencliu
force-pushed
the
virtiofs_migration_nfs
branch
from
1b8661d to
5c5af34
Compare
hellohellenmao
suggested changes
Feb 8, 2025
| - file_handles: | ||
| required_virtiofsd_version = [1.13.0,) | ||
| virtiofsd_version_cmd = rpm -q virtiofsd | cut -d- -f2 | ||
| fs_binary_extra_options_targetfs = " --modcaps=+dac_read_search" |
There was a problem hiding this comment.
Should be += but not =, or the migration will fail as the cache mode does not match to source daemon.
|
And for The current test results: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following testing matrix is covered:
cache mode:
auto, never, always, metadata
writeback:
enabled and disabled
allow-direct-io
enabled and disabled
file-handles
mandatory and never
ID: 2966