Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snp_basic_config: Add snp basic config test case #4224

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

snp_basic_config: Add snp basic config test case #4224

wants to merge 2 commits into from
+153 −0

Conversation

zixi-chen
Copy link
Contributor

@zixi-chen zixi-chen commented Dec 2, 2024 •
edited
Loading

ID: 2863

@zixi-chen zixi-chen force-pushed the snp_basic branch 2 times, most recently from 73ba367 to c184836 Compare December 2, 2024 09:26
@zixi-chen
Copy link
Contributor Author

zixi-chen commented Dec 3, 2024 •
edited
Loading

@XueqiangWei @zhencliu @JinLiul Could you please help to review this?

@XueqiangWei
Copy link
Contributor

@zixi-chen Commit signature has been enabled, please repush the pullreq with -S. Thanks.

@zixi-chen
Copy link
Contributor Author

@zixi-chen Commit signature has been enabled, please repush the pullreq with -S. Thanks.

Done, thanks.

@zixi-chen
Copy link
Contributor Author

Update a retry function to fetch certs from the server.
...
ERROR: Unable to fetch VCEK from URL: 429
Error: Unable to fetch VCEK from URL: 429
Command 'snpguest fetch vcek pem genoa ./ attestation-report.bin' failed. Retry 1/3 in 20s...
The AMD ARK was self-signed!
The AMD ASK was signed by the AMD ARK!
The VCEK was signed by the AMD ASK!
...

@zhencliu zhencliu mentioned this pull request Dec 13, 2024
Open
@XueqiangWei
Copy link
Contributor

@zixi-chen two commits, only one signed, please check it, thanks.

@zixi-chen zixi-chen force-pushed the snp_basic branch 3 times, most recently from 210e960 to 36fc358 Compare December 18, 2024 10:38
@zixi-chen
Copy link
Contributor Author

zixi-chen commented Dec 19, 2024 •
edited
Loading

@zhenchao
@XueqiangWei
Update the changes based on the comments, Could you please review them again? Thanks!
(1/3) Host_RHEL.m9.u6.v0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9..0.x86_64.io-github-autotest-qemu.snp_basic_config.policy_default.q35: STARTED
(1/3) Host_RHEL.m9.u6.v0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9..0.x86_64.io-github-autotest-qemu.snp_basic_config.policy_default.q35: PASS (93.14 s)
(2/3) Host_RHEL.m9.u6.v0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9..0.x86_64.io-github-autotest-qemu.snp_basic_config.policy_debug.q35: STARTED
(2/3) Host_RHEL.m9.u6.v0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9..0.x86_64.io-github-autotest-qemu.snp_basic_config.policy_debug.q35: PASS (91.80 s)
(3/3) Host_RHEL.m9.u6.v0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.0.x86_64.io-github-autotest-qemu.snp_basic_config.policy_singlesocket.q35: STARTED
(3/3) Host_RHEL.m9.u6.v0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9..0.x86_64.io-github-autotest-qemu.snp_basic_config.policy_singlesocket.q35: CANCEL: Host cpu has more than 1 socket, skip the case. (3.10 s)

@zixi-chen zixi-chen force-pushed the snp_basic branch 2 times, most recently from 37ed748 to c54fe62 Compare December 19, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhencliu zhencliu zhencliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zixi-chen @XueqiangWei @zhencliu