-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware_control_evaluator): add new steering metrics #10012
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
50f6245
to
02cc270
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10012 +/- ##
==========================================
- Coverage 29.78% 29.76% -0.02%
==========================================
Files 1435 1436 +1
Lines 108277 108337 +60
Branches 42946 42959 +13
==========================================
Hits 32249 32249
- Misses 72898 72957 +59
- Partials 3130 3131 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9f9a092
to
9ab7403
Compare
Signed-off-by: xtk8532704 <[email protected]>
Signed-off-by: xtk8532704 <[email protected]>
Signed-off-by: xtk8532704 <[email protected]>
d4cb9b8
to
c826483
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
let's merge before relase if any other concerns! |
Description
steering_angle
,steering_rate
, andsteering_acceleration
, which take info from/vehicle/status/steering_status
as inputs.By the new metrics, I observed that steering_acc is very unstable, possibly due to a potential problem with the controller not limiting it.
Here is a sample in Psim with statistics. Uploading Screencast from 2025年01月22日 17時58分10秒.webm…
statistic results:
Related links
Parent Issue:
How was this PR tested?
Psim:
Screencast from 2025年01月23日 17時06分58秒.webm
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.