Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(goal_planner): fix waiting approval path of backward parking #10015

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jan 23, 2025

Description

due to #9829, the waiting approval path is cut to original goal, but this is intended for ARC_BACKWARD.
when using ARC_BACKWARD, the start pose of parking is after goal pose, so the path should be generated to the start pose

before

stuck with arc_backward

image

image

after

works with arc_backward

image

no problem with shift too

image

Related links

Parent Issue:

  • Link

How was this PR tested?

psim

2025/01/24 https://evaluation.tier4.jp/evaluation/reports/bfe6f4b8-3f63-5172-aa67-3f143be862fe/?project_id=prd_jt

2025/01/24 https://evaluation.tier4.jp/evaluation/reports/ea06eaa1-6799-57a1-8092-42af4ffcd901/?project_id=prd_jt

2025/01/25 https://evaluation.tier4.jp/evaluation/reports/613f7ab0-7524-5f50-ab18-e6ef11d26fd0/?project_id=prd_jt

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 23, 2025
Copy link

github-actions bot commented Jan 23, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 29.76%. Comparing base (40aff9f) to head (37f15a8).

Files with missing lines Patch % Lines
...th_goal_planner_module/src/goal_planner_module.cpp 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10015      +/-   ##
==========================================
- Coverage   29.78%   29.76%   -0.02%     
==========================================
  Files        1436     1439       +3     
  Lines      108310   108373      +63     
  Branches    42956    42958       +2     
==========================================
  Hits        32256    32256              
- Misses      72922    72985      +63     
  Partials     3132     3132              
Flag Coverage Δ *Carryforward flag
differential 0.50% <0.00%> (?)
total 29.78% <ø> (+<0.01%) ⬆️ Carriedforward from 40aff9f

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 force-pushed the fix/goal_backward_parking branch from 219fa9e to 7cbdbe2 Compare January 24, 2025 02:47
@github-actions github-actions bot added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Jan 24, 2025
@kosuke55 kosuke55 force-pushed the fix/goal_backward_parking branch from 7cbdbe2 to 8f4be01 Compare January 24, 2025 02:49
@github-actions github-actions bot removed the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Jan 24, 2025
@kosuke55 kosuke55 force-pushed the fix/goal_backward_parking branch from 8f4be01 to 37f15a8 Compare January 25, 2025 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

2 participants