Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: test traffic light with an invalid ID #37

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: test traffic light with an invalid ID #37

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47ec02a
invalid ID test added.
HansOersted Dec 9, 2024
b45f4c2
style(pre-commit): autofix
pre-commit-ci[bot] Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions autoware_lanelet2_extension/test/src/test_regulatory_elements.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,18 @@ class TestSuite : public ::testing::Test // NOLINT for gtest
~TestSuite() override = default;
};

TEST(TestSuite, InvalidIdTrafficLight)
{ // NOLINT for gtest
int invalid_id = -1;

// create a traffic light with an invalid ID
auto invalid_tl = lanelet::autoware::AutowareTrafficLight::make(
invalid_id, lanelet::AttributeMap(), convertToVector(LineString3d()), LineString3d(),
convertToVector(LineString3d()));
Comment on lines +57 to +60
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn’t it fail to call make if the ID is invalid?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HansOersted Please response this.


EXPECT_EQ(invalid_tl->id(), invalid_id);
}

TEST(TestSuite, FactoryConstructsTrafficLight) // NOLINT for gtest
{
Point3d p1;
Expand Down
Loading