Integrate ConvertSubnetTx AvalancheGo #5430
sukantoraymondAnnotations
2 errors and 69 warnings
|
Lint:
cmd/blockchaincmd/add_validator.go#L195
commentFormatting: put a space between `//` and comment text (gocritic)
|
|
Lint
issues found
|
|
e2e tests (\[Public Subnet\], ubuntu-latest)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v3, actions/setup-node@v3, nick-fields/retry@v2, webfactory/[email protected], actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
e2e tests (\[Public Subnet\], ubuntu-latest)
No files were found with the provided path: ~/.avalanche-cli/
!~/.avalanche-cli/bin/
!~/.avalanche-cli/snapshots. No artifacts will be uploaded.
|
|
e2e tests (\[Local Subnet\], ubuntu-latest)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v3, actions/setup-node@v3, nick-fields/retry@v2, webfactory/[email protected], actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
e2e tests (\[Local Subnet\], ubuntu-latest)
No files were found with the provided path: ~/.avalanche-cli/
!~/.avalanche-cli/bin/
!~/.avalanche-cli/snapshots. No artifacts will be uploaded.
|
|
e2e tests (\[Upgrade local network\], ubuntu-latest)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v3, actions/setup-node@v3, nick-fields/retry@v2, webfactory/[email protected], actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
e2e tests (\[Upgrade local network\], ubuntu-latest)
No files were found with the provided path: ~/.avalanche-cli/
!~/.avalanche-cli/bin/
!~/.avalanche-cli/snapshots. No artifacts will be uploaded.
|
|
e2e tests (\[Upgrade public network\], ubuntu-latest)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v3, actions/setup-node@v3, nick-fields/retry@v2, webfactory/[email protected], actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
e2e tests (\[Upgrade public network\], ubuntu-latest)
No files were found with the provided path: ~/.avalanche-cli/
!~/.avalanche-cli/bin/
!~/.avalanche-cli/snapshots. No artifacts will be uploaded.
|
|
e2e tests (\[Upgrade expect network failure\], ubuntu-latest)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v3, actions/setup-node@v3, nick-fields/retry@v2, webfactory/[email protected], actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
e2e tests (\[Upgrade expect network failure\], ubuntu-latest)
No files were found with the provided path: ~/.avalanche-cli/
!~/.avalanche-cli/bin/
!~/.avalanche-cli/snapshots. No artifacts will be uploaded.
|
|
e2e tests (\[Docker\], ubuntu-latest)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v3, actions/setup-node@v3, nick-fields/retry@v2, webfactory/[email protected], actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
e2e tests (\[Docker\], ubuntu-latest)
No files were found with the provided path: ~/.avalanche-cli/
!~/.avalanche-cli/bin/
!~/.avalanche-cli/snapshots. No artifacts will be uploaded.
|
|
Golang Unit Tests v1.21.7 (ubuntu-20.04)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
e2e tests (\[Error handling\], ubuntu-latest)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v3, actions/setup-node@v3, nick-fields/retry@v2, webfactory/[email protected], actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
e2e tests (\[Error handling\], ubuntu-latest)
No files were found with the provided path: ~/.avalanche-cli/
!~/.avalanche-cli/bin/
!~/.avalanche-cli/snapshots. No artifacts will be uploaded.
|
|
e2e tests (\[APM\], ubuntu-latest)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v3, actions/setup-node@v3, nick-fields/retry@v2, webfactory/[email protected], actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
e2e tests (\[APM\], ubuntu-latest)
No files were found with the provided path: ~/.avalanche-cli/
!~/.avalanche-cli/bin/
!~/.avalanche-cli/snapshots. No artifacts will be uploaded.
|
|
e2e tests (\[Root\], ubuntu-latest)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v3, actions/setup-node@v3, nick-fields/retry@v2, webfactory/[email protected], actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
e2e tests (\[Root\], ubuntu-latest)
No files were found with the provided path: ~/.avalanche-cli/
!~/.avalanche-cli/bin/
!~/.avalanche-cli/snapshots. No artifacts will be uploaded.
|
|
e2e tests (\[Subnet\], ubuntu-latest)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v3, actions/setup-node@v3, nick-fields/retry@v2, webfactory/[email protected], actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
e2e tests (\[Subnet\], ubuntu-latest)
No files were found with the provided path: ~/.avalanche-cli/
!~/.avalanche-cli/bin/
!~/.avalanche-cli/snapshots. No artifacts will be uploaded.
|
|
e2e tests (\[Key\], ubuntu-latest)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v3, actions/setup-node@v3, nick-fields/retry@v2, webfactory/[email protected], actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
e2e tests (\[Key\], ubuntu-latest)
No files were found with the provided path: ~/.avalanche-cli/
!~/.avalanche-cli/bin/
!~/.avalanche-cli/snapshots. No artifacts will be uploaded.
|
|
e2e tests (\[Upgrade expect network failure\], macos-13)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v3, actions/setup-node@v3, nick-fields/retry@v2, webfactory/[email protected], actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
e2e tests (\[Upgrade expect network failure\], macos-13)
No files were found with the provided path: ~/.avalanche-cli/
!~/.avalanche-cli/bin/
!~/.avalanche-cli/snapshots. No artifacts will be uploaded.
|
|
Lint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-go@v3, actions/checkout@v3, golangci/golangci-lint-action@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Lint:
pkg/subnet/public.go#L863
early-return: if c { ... } else { ... return } can be simplified to if !c { ... return } ... (revive)
|
|
Lint:
pkg/subnet/public.go#L122
unused-receiver: method receiver 'd' is not referenced in method's body, consider removing or renaming it as _ (revive)
|
|
Lint:
pkg/subnet/public.go#L128
unused-receiver: method receiver 'd' is not referenced in method's body, consider removing or renaming it as _ (revive)
|
|
Lint:
pkg/subnet/public.go#L123
unused-parameter: parameter 'message' seems to be unused, consider removing or renaming it as _ (revive)
|
|
Lint:
pkg/subnet/public.go#L129
unused-parameter: parameter 'balance' seems to be unused, consider removing or renaming it as _ (revive)
|
|
Lint:
pkg/subnet/public.go#L130
unused-parameter: parameter 'signer' seems to be unused, consider removing or renaming it as _ (revive)
|
|
Lint:
pkg/subnet/public.go#L131
unused-parameter: parameter 'changeOwner' seems to be unused, consider removing or renaming it as _ (revive)
|
|
Lint:
pkg/subnet/public.go#L132
unused-parameter: parameter 'message' seems to be unused, consider removing or renaming it as _ (revive)
|
|
Lint:
cmd/blockchaincmd/remove_validator.go#L187
unused-parameter: parameter 'validationID' seems to be unused, consider removing or renaming it as _ (revive)
|
|
Lint:
cmd/blockchaincmd/remove_validator.go#L193
unused-parameter: parameter 'nodeID' seems to be unused, consider removing or renaming it as _ (revive)
|
|
e2e tests (\[Node create\], ubuntu-latest)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v3, actions/setup-node@v3, nick-fields/retry@v2, webfactory/[email protected], actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
e2e tests (\[Node create\], ubuntu-latest)
No files were found with the provided path: ~/.avalanche-cli/
!~/.avalanche-cli/bin/
!~/.avalanche-cli/snapshots. No artifacts will be uploaded.
|
|
e2e tests (\[Node devnet\], ubuntu-latest)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v3, actions/setup-node@v3, nick-fields/retry@v2, webfactory/[email protected], actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
e2e tests (\[Node devnet\], ubuntu-latest)
No files were found with the provided path: ~/.avalanche-cli/
!~/.avalanche-cli/bin/
!~/.avalanche-cli/snapshots. No artifacts will be uploaded.
|
|
e2e tests (\[Key\], macos-13)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v3, actions/setup-node@v3, nick-fields/retry@v2, webfactory/[email protected], actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
e2e tests (\[Key\], macos-13)
No files were found with the provided path: ~/.avalanche-cli/
!~/.avalanche-cli/bin/
!~/.avalanche-cli/snapshots. No artifacts will be uploaded.
|
|
e2e tests (\[APM\], macos-13)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v3, actions/setup-node@v3, nick-fields/retry@v2, webfactory/[email protected], actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
e2e tests (\[APM\], macos-13)
No files were found with the provided path: ~/.avalanche-cli/
!~/.avalanche-cli/bin/
!~/.avalanche-cli/snapshots. No artifacts will be uploaded.
|
|
e2e tests (\[Subnet Compatibility\], ubuntu-latest)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v3, actions/setup-node@v3, nick-fields/retry@v2, webfactory/[email protected], actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
e2e tests (\[Subnet Compatibility\], ubuntu-latest)
No files were found with the provided path: ~/.avalanche-cli/
!~/.avalanche-cli/bin/
!~/.avalanche-cli/snapshots. No artifacts will be uploaded.
|
|
Golang Unit Tests v1.21.7 (macos-13)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
e2e tests (\[Upgrade public network\], macos-13)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v3, actions/setup-node@v3, nick-fields/retry@v2, webfactory/[email protected], actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
e2e tests (\[Upgrade public network\], macos-13)
No files were found with the provided path: ~/.avalanche-cli/
!~/.avalanche-cli/bin/
!~/.avalanche-cli/snapshots. No artifacts will be uploaded.
|
|
e2e tests (\[Network\], ubuntu-latest)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v3, actions/setup-node@v3, nick-fields/retry@v2, webfactory/[email protected], actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
e2e tests (\[Network\], ubuntu-latest)
No files were found with the provided path: ~/.avalanche-cli/
!~/.avalanche-cli/bin/
!~/.avalanche-cli/snapshots. No artifacts will be uploaded.
|
|
e2e tests (\[Error handling\], macos-13)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v3, actions/setup-node@v3, nick-fields/retry@v2, webfactory/[email protected], actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
e2e tests (\[Error handling\], macos-13)
No files were found with the provided path: ~/.avalanche-cli/
!~/.avalanche-cli/bin/
!~/.avalanche-cli/snapshots. No artifacts will be uploaded.
|
|
e2e tests (\[Upgrade local network\], macos-13)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v3, actions/setup-node@v3, nick-fields/retry@v2, webfactory/[email protected], actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
e2e tests (\[Upgrade local network\], macos-13)
No files were found with the provided path: ~/.avalanche-cli/
!~/.avalanche-cli/bin/
!~/.avalanche-cli/snapshots. No artifacts will be uploaded.
|
|
e2e tests (\[Package Management\], ubuntu-latest)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v3, actions/setup-node@v3, nick-fields/retry@v2, webfactory/[email protected], actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
e2e tests (\[Package Management\], ubuntu-latest)
No files were found with the provided path: ~/.avalanche-cli/
!~/.avalanche-cli/bin/
!~/.avalanche-cli/snapshots. No artifacts will be uploaded.
|
|
e2e tests (\[Subnet\], macos-13)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v3, actions/setup-node@v3, nick-fields/retry@v2, webfactory/[email protected], actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
e2e tests (\[Subnet\], macos-13)
No files were found with the provided path: ~/.avalanche-cli/
!~/.avalanche-cli/bin/
!~/.avalanche-cli/snapshots. No artifacts will be uploaded.
|
|
e2e tests (\[Root\], macos-13)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v3, actions/setup-node@v3, nick-fields/retry@v2, webfactory/[email protected], actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
e2e tests (\[Root\], macos-13)
No files were found with the provided path: ~/.avalanche-cli/
!~/.avalanche-cli/bin/
!~/.avalanche-cli/snapshots. No artifacts will be uploaded.
|
|
e2e tests (\[Local Subnet\], macos-13)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v3, actions/setup-node@v3, nick-fields/retry@v2, webfactory/[email protected], actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
e2e tests (\[Local Subnet\], macos-13)
No files were found with the provided path: ~/.avalanche-cli/
!~/.avalanche-cli/bin/
!~/.avalanche-cli/snapshots. No artifacts will be uploaded.
|
|
e2e tests (\[Subnet Compatibility\], macos-13)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v3, actions/setup-node@v3, nick-fields/retry@v2, webfactory/[email protected], actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
e2e tests (\[Subnet Compatibility\], macos-13)
No files were found with the provided path: ~/.avalanche-cli/
!~/.avalanche-cli/bin/
!~/.avalanche-cli/snapshots. No artifacts will be uploaded.
|
|
e2e tests (\[Network\], macos-13)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v3, actions/setup-node@v3, nick-fields/retry@v2, webfactory/[email protected], actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
e2e tests (\[Network\], macos-13)
No files were found with the provided path: ~/.avalanche-cli/
!~/.avalanche-cli/bin/
!~/.avalanche-cli/snapshots. No artifacts will be uploaded.
|
|
e2e tests (\[Package Management\], macos-13)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v3, actions/setup-node@v3, nick-fields/retry@v2, webfactory/[email protected], actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
e2e tests (\[Package Management\], macos-13)
No files were found with the provided path: ~/.avalanche-cli/
!~/.avalanche-cli/bin/
!~/.avalanche-cli/snapshots. No artifacts will be uploaded.
|