Acp 77 local network (#2357)

* acp-77

* fix lint

* address comments

* fix test

* make pos coming soon

* update test

* Prompts for Subnet create acp77 (#2150)

* prompt addresses

* fix lint

* fix lint

* fix lint

* fix lint

* add flags

* address comments

* fix test

* address comments

* fix lint

---------

Signed-off-by: sukantoraymond <[email protected]>

* Validator prompt acp77 (#2152)

* prompt addresses

* fix lint

* fix lint

* fix lint

* fix lint

* add flags

* validator prompt

* bootstrap validators

* add mock

* fix lint

* update prompt validator

* update prompt validator

* implement prompts

* fix prompt mock

* update sidecar

* update prompts

* update prompts

* refactor

* update prompts

* update prompts

* use default balance and weight

* generate new node ids and bls

* fix lint

* add flags

* add flags

* address comments

* address comments

* address comments

* move validator prompt to deploy

* address comments

* address comments

* fix lint

* address comments

* address comments

* fix test

* address comments

* fix lint

* address coments

* address coments

* fix test

* fix test

* fix test

* fix lint

---------

Signed-off-by: sukantoraymond <[email protected]>

* Genesis icm (#2154)

* adding teleporter contract to genesis

* fixes for icm on genesis

* add icm from a given embedded file

* add function to deploy ICM registry

* creating mapping values

* add consts

* make local deploy to work

* do not print info for icm support addrs

* nit

* nit

* fix wiz stuff

* address PR comments

* filter based on balance

* add unit tests

* Update cmd/blockchaincmd/describe.go

Co-authored-by: Michael Kaplan <[email protected]>
Signed-off-by: felipemadero <[email protected]>

* lint

---------

Signed-off-by: felipemadero <[email protected]>
Co-authored-by: Michael Kaplan <[email protected]>

* lint

* Genesis poa (#2164)

* prompt addresses

* fix lint

* fix lint

* fix lint

* fix lint

* add flags

* adding teleporter contract to genesis

* validator prompt

* bootstrap validators

* add mock

* fix lint

* update prompt validator

* update prompt validator

* fixes for icm on genesis

* add icm from a given embedded file

* add function to deploy ICM registry

* creating mapping values

* add consts

* make local deploy to work

* do not print info for icm support addrs

* nit

* implement prompts

* fix prompt mock

* update sidecar

* update prompts

* update prompts

* refactor

* nit

* update prompts

* fix wiz stuff

* update prompts

* use default balance and weight

* generate new node ids and bls

* fix lint

* add flags

* add flags

* add a function to initialize PoA manager

* add lib folder

* address comments

* address comments

* address comments

* move validator prompt to deploy

* address comments

* address comments

* fix lint

* address comments

* address comments

* fix test

* address PR comments

* basic PoA manager setting

* lint

* address comments

* fix lint

* fix e2e

* fix merge

* fix merge

* filter based on balance

* add unit tests

* nit

* address PR comments

* Update cmd/blockchaincmd/describe.go

Co-authored-by: Michael Kaplan <[email protected]>
Signed-off-by: felipemadero <[email protected]>

* nit

* address PR comments

* lint

---------

Signed-off-by: sukantoraymond <[email protected]>
Signed-off-by: felipemadero <[email protected]>
Co-authored-by: Raymond Sukanto <[email protected]>
Co-authored-by: Michael Kaplan <[email protected]>

* Signature aggregator sdk (#2149)

* wip

* go mod tidy

* use awm-relayer@main

* fixes

* use latest awm-relayer pkg  which caused upgrade on coreth and avago  - has to be resolved

* use latest anr and rm prometheus metrics

* check for errors

* lint

* mv to sdk/interchain

* some refactoring and added unittests

* fix license

* fix unittest for now

* fix lint

* allow empty subnetID
add usage working example

* rm error msg from example

* refactor to address felipe feedback

* we should remove this from the test in favour of https://github.com/ava-labs/awm-relayer/blob/main/signature-aggregator/aggregator/aggregator_test.go - we just use exposed API

* update readme example

* rm goconst fix CI

* put `- goconst` back

* resolve conficts

---------

Co-authored-by: Raymond Sukanto <[email protected]>

* Fix acp 77 ci (#2204)

* use latest anr main

* tidy

* bump e2e avago version to be dynamic fee compatible

* fix e2e for dynamic fees

* lint

* ACP 77 new commands (#2172)

* prompt addresses

* fix lint

* fix lint

* fix lint

* fix lint

* add flags

* adding teleporter contract to genesis

* validator prompt

* bootstrap validators

* add mock

* fix lint

* update prompt validator

* update prompt validator

* fixes for icm on genesis

* add icm from a given embedded file

* add function to deploy ICM registry

* creating mapping values

* add consts

* make local deploy to work

* do not print info for icm support addrs

* nit

* implement prompts

* fix prompt mock

* update sidecar

* update prompts

* update prompts

* refactor

* nit

* update prompts

* fix wiz stuff

* update prompts

* use default balance and weight

* generate new node ids and bls

* fix lint

* add flags

* add flags

* add a function to initialize PoA manager

* add lib folder

* address comments

* address comments

* address comments

* move validator prompt to deploy

* address comments

* address comments

* fix lint

* address comments

* address comments

* fix test

* address PR comments

* basic PoA manager setting

* lint

* address comments

* fix lint

* fix e2e

* fix merge

* fix merge

* convert Subnet Tx

* convert subnet

* register validator

* add validator

* mock

* remove validator

* update weight

* update weight

* add flags add validator

* remove validator update

* refactor addvalidator

* use node id as arg in addvalidator

* fix change weight arg

* resolve merge conflict

* fix lint

* address comments

* fix lint

* Enable non sov subnets (#2203)

* subnet create non sov

* support non sov blockchain

* update test

* update tests

* update tests

* update test

* update tests

* update tests

* fix test

* update tests

* Rename Subnet to L1 for new commands ACP77 (#2209)

* rename convert subnet

* rename to l1

* fix lint

* fix lint

* fix lint

* fix lint

* Integrate ConvertSubnetTx AvalancheGo  (#2213)

* complete implementation of avalanche go convertsubnet

* update relayer

* update convertsubnettx

* update avalanchego

* update avalanche go

* update avalanche go

* dont prompt control key for sov

* add tx cases for convert subnet tx (#2218)

* Poa integration (#2212)

* use latest contract

* point to latest convert subnet avago PR

* nit

* use fixed anr

* nit

* add subnet conversion id calculation

* created unsigned warp message

* fixed local network deploy

* added signing

* now this is working

* using latest avago master + awm relayer

* working pretty well

* ready

* lint

* address PR comments

* nit

---------

Signed-off-by: sukantoraymond <[email protected]>
Co-authored-by: sukantoraymond <[email protected]>

* fix lint

* reverse sidecar sov logic

* fix merge

* add poa setup to blockchain deploy (#2219)

* add setup poa to blockchain deploy

* add command

* add proposervm update

* proposervm flag for nodes

* nit

* nit

* fixed dynamic fees params calculation

* only adding tracked apis to apis in sidecar

* improve prompts

* fixing various stuff

* add upgrade file

* use anr etna enabled

* keep upgrade on sync

* workin

* almost working

* working1

* Update cmd/keycmd/transfer.go

Co-authored-by: Meaghan FitzGerald <[email protected]>
Signed-off-by: felipemadero <[email protected]>

* fix some lint

* address PR comments

* missing file

* nit

---------

Signed-off-by: felipemadero <[email protected]>
Signed-off-by: sukantoraymond <[email protected]>
Co-authored-by: Meaghan FitzGerald <[email protected]>
Co-authored-by: sukantoraymond <[email protected]>

---------

Signed-off-by: sukantoraymond <[email protected]>
Signed-off-by: felipemadero <[email protected]>
Co-authored-by: felipemadero <[email protected]>
Co-authored-by: Meaghan FitzGerald <[email protected]>

* fix lint

---------

Signed-off-by: sukantoraymond <[email protected]>
Signed-off-by: felipemadero <[email protected]>
Co-authored-by: felipemadero <[email protected]>
Co-authored-by: Meaghan FitzGerald <[email protected]>

---------

Signed-off-by: sukantoraymond <[email protected]>
Signed-off-by: felipemadero <[email protected]>
Co-authored-by: Felipe Madero <[email protected]>
Co-authored-by: Meaghan FitzGerald <[email protected]>

* fix merge

* Track subnet refactor  (#2228)

* refactor subnet sync

* fix lint

* Remove redundancies (#2229)

* remove redundant code

* fix lint

* fix lint

* Convert Subnet in  1 command (#2230)

* one command deploy

* use default private key to deploy validator manager contract

* fix lint

* remove redundant code

* address comments

---------

Signed-off-by: sukantoraymond <[email protected]>

---------

Signed-off-by: sukantoraymond <[email protected]>

* Fix generate new node id and bls info (#2237)

* generate new node id

* fix lint

* assume blockchain endpoint only for cli managed node sync (#2241)

* fix merge

* node local PoC (#2216)

* node local init

* hardcode etna devnet config

* wip

* rm not needed utils

* ready for draft PR

* nits
rm unused struct

* refactor - wip

* make sure we can resume without prompts

* add custom network and local cluster

* devnet instead of custom network, rm custom

* go mod tidy

* upgrade.json for etna devnet

* more local cluster

* separate between local network and local cluster

* working

* nit

* fix plugin

* nit

* improve snapshot management

* fix bug

* nit

* proper etna devnet boostrappers

* fix bug with local rootdir

* remove global node config stuff

* destroy node data and processes if bad start

* nit

* always use fresh staking keys

* nit

* so less flags

* add back fast boot time

* add checks for local cluster. minor refactor (#2239)

* add checks for local cluster
minor refactoring

* fix test

* addressed Felipe feedback

---------

Signed-off-by: arturrez <[email protected]>

* bump anr

* fixes for convert flow

* add check for already initialized error on PoA init

* nit

* use anr main

* fix merge

* Local mkdir rootdir (#2245)

* make sure rootDir exists

* mv it to proper location

* it's done before the start

* update anr

* Integrate local devnet (#2254)

* integrate deploy

* integrate deploy

* Fix lint

* address comments

* address comments

* Integrate start (#2262)

* integrate start

* integrate start

* update etna network

* integrate start

* integrate start

* finish integrate start

* fix lint

* stop existing local avalanchego

* more robust

---------

Signed-off-by: arturrez <[email protected]>
Signed-off-by: sukantoraymond <[email protected]>
Co-authored-by: Felipe Madero <[email protected]>
Co-authored-by: sukantoraymond <[email protected]>

* go 1.22.8 for dockerfile

* Node local status (#2261)

* node local init

* hardcode etna devnet config

* wip

* rm not needed utils

* ready for draft PR

* nits
rm unused struct

* refactor - wip

* make sure we can resume without prompts

* add custom network and local cluster

* devnet instead of custom network, rm custom

* go mod tidy

* upgrade.json for etna devnet

* more local cluster

* separate between local network and local cluster

* working

* nit

* fix plugin

* nit

* improve snapshot management

* fix bug

* nit

* proper etna devnet boostrappers

* fix bug with local rootdir

* remove global node config stuff

* destroy node data and processes if bad start

* nit

* always use fresh staking keys

* nit

* so less flags

* add back fast boot time

* add checks for local cluster. minor refactor (#2239)

* add checks for local cluster
minor refactoring

* fix test

* addressed Felipe feedback

---------

Signed-off-by: arturrez <[email protected]>

* bump anr

* fixes for convert flow

* add check for already initialized error on PoA init

* nit

* use anr main

* fix merge

* Local mkdir rootdir (#2245)

* make sure rootDir exists

* mv it to proper location

* it's done before the start

* update anr

* add `node local status` command

* add logging.Green.Wrap(
lint

* lint

* fix merge

* make `node status` works with local clusters
more lint fixes

* detect Stopped state for local clusterName passed as arg

* add stopped status to all local clusters

* undo change

---------

Signed-off-by: arturrez <[email protected]>
Signed-off-by: sukantoraymond <[email protected]>
Co-authored-by: Felipe Madero <[email protected]>
Co-authored-by: sukantoraymond <[email protected]>

* fix lint

* fix merge

* Register validator local (#2247)

* node local init

* hardcode etna devnet config

* wip

* rm not needed utils

* ready for draft PR

* nits
rm unused struct

* refactor - wip

* make sure we can resume without prompts

* add custom network and local cluster

* devnet instead of custom network, rm custom

* go mod tidy

* upgrade.json for etna devnet

* more local cluster

* partial work

* separate between local network and local cluster

* working

* nit

* fix plugin

* nit

* improve snapshot management

* fix bug

* nit

* proper etna devnet boostrappers

* fix bug with local rootdir

* remove global node config stuff

* destroy node data and processes if bad start

* nit

* always use fresh staking keys

* nit

* so less flags

* add back fast boot time

* add checks for local cluster. minor refactor (#2239)

* add checks for local cluster
minor refactoring

* fix test

* addressed Felipe feedback

---------

Signed-off-by: arturrez <[email protected]>

* bump anr

* fixes for convert flow

* add check for already initialized error on PoA init

* nit

* not to much further to have a complete flow

* ok esto esta funcionando

* started refactoring

* use relayer branch

* partial work

* use anr main

* working for devnets

* is this working

* working for local

* nit

* working

* bump anr

* Fix merge

* Fix merge

* Fix merge

* Update avalanche go ledger (#2234)

* update avalanche go ledger

* fixes

* nit

* update prompt

* update tests

* update avalanchego

---------

Co-authored-by: Felipe Madero <[email protected]>
Co-authored-by: arturrez <[email protected]>

* lint

* fix merge

* nits

* lint

* fix merge

---------

Signed-off-by: arturrez <[email protected]>
Signed-off-by: sukantoraymond <[email protected]>
Co-authored-by: Artur Reznikov <[email protected]>
Co-authored-by: arturrez <[email protected]>
Co-authored-by: sukantoraymond <[email protected]>

* fix lint

* lint

* Validator removal (#2267)

* node local init

* hardcode etna devnet config

* wip

* rm not needed utils

* ready for draft PR

* nits
rm unused struct

* refactor - wip

* make sure we can resume without prompts

* add custom network and local cluster

* devnet instead of custom network, rm custom

* go mod tidy

* upgrade.json for etna devnet

* more local cluster

* partial work

* separate between local network and local cluster

* working

* nit

* fix plugin

* nit

* improve snapshot management

* fix bug

* nit

* proper etna devnet boostrappers

* fix bug with local rootdir

* remove global node config stuff

* destroy node data and processes if bad start

* nit

* always use fresh staking keys

* nit

* so less flags

* add back fast boot time

* add checks for local cluster. minor refactor (#2239)

* add checks for local cluster
minor refactoring

* fix test

* addressed Felipe feedback

---------

Signed-off-by: arturrez <[email protected]>

* bump anr

* fixes for convert flow

* add check for already initialized error on PoA init

* nit

* not to much further to have a complete flow

* ok esto esta funcionando

* started refactoring

* use relayer branch

* partial work

* use anr main

* working for devnets

* is this working

* working for local

* nit

* working

* bump anr

* initialization

* nit

* add last step

* split

* nit

* nit

* nit

* improval

* Fix merge

* Fix merge

* Fix merge

* nits

* lint

* fix merge

* add tracing function for tx on blockchain

* now I have control of logs

* added log level flag for aggregator

* improve err management a bit more

* working

* adjust weights

* nits

* nit

* nits

* lint

* nit

* nit

* nit

* lint

---------

Signed-off-by: arturrez <[email protected]>
Signed-off-by: sukantoraymond <[email protected]>
Co-authored-by: Artur Reznikov <[email protected]>
Co-authored-by: arturrez <[email protected]>
Co-authored-by: sukantoraymond <[email protected]>

* lint

* make sure that we return empty clusterconf if cluster not found (#2269)

* Fix case where node is not generated before calling subnet deploy (#2270)

* fix no local

* fix generatre nod eid

* Use existing cluster deploy (#2271)

* fix no local

* fix generatre nod eid

* integrate deploy

* fix lint

* rm local machine cluster

* check for bootstrap endpoints before populating this slice

* lint

* fix inventory err for local (#2272)

* fix merge

---------

Co-authored-by: Artur Reznikov <[email protected]>
Co-authored-by: arturrez <[email protected]>

* Acp77 remote etna devnet (#2233)

* etna devnet constants

* add custom bootrap conf to node create

* Update cmd/nodecmd/create.go

Co-authored-by: Michael Kaplan <[email protected]>
Signed-off-by: arturrez <[email protected]>

* add unittests for ip:port pair verificatoion

* update etna bootstrap info

* add  AvalancheGoConfigOptions struct

* etnadevnet network model

* write data to files

* err handling

* support etna devnet

* fix address input

* allow public access to rpc endpoint for etna devnet

* add ux to report public access to user

* read bls info and nodeid for the cluster

* added 0x to string, added log

* fix issue with http_host reverted after sync

* resolve conflict

* lint

* after merge fixes

---------

Signed-off-by: arturrez <[email protected]>
Co-authored-by: Michael Kaplan <[email protected]>

* properly create nodes dir and cluster config file (#2273)

* Acp use etna devnet (#2275)

* fix

* push

* Cleanup AddValidator command (#2276)

* cleanup addvalidator command

* fix lint

* fix lint

* dont print err if fail on repeat

* fix lint (#2277)

* fix err msg

* print all errors (#2279)

* Check max balance on add validator (#2278)

* regen mocks

* addres PR comment

* address PR comment

* Continue on error remove validator (#2280)

* contiunue if validator removal process already started

* address PR comment

* Acp77 remote enta cluster fixes (#2281)

* put getClusterBootstrapValidators back

* lint

* add remore cluster helper for signature aggr

* lint

* fix merge

* update avalanche go tag

* remove dummy txs

* remove dummy txs

* Acp77 e2e (#2287)

* print all errors

* e2e acp77

* update test

* update test

* update test

* fix merge

* fix merge

* fix test

* fix lint

* update test

* update test

* fix ci

* update flags

* update tests

* update test

* update test

* update test

* update test

* update test

* update tests

* Acp77 e2e etna add remove validator flow (#2290)

* etna devnet add remove validator

* add remove validator

* fixes

* fix

* get blockchain ID from output

* more fixes

* lint

* add key

* add sov validator e2e on linux only

* fix typo

* use macosx becuse of the avalanchego poc.5 binary in the assets

* fix test

* update test

---------

Signed-off-by: sukantoraymond <[email protected]>
Co-authored-by: arturrez <[email protected]>

* fix lint

* integrate main change

* Fix lint

* update binary for test

* add node configs to local cluster (#2296)

* Acp 77 fix (#2284)

* fix for meag env to work

* lint

* fix

* use anr without issue

* use anr main

* improve checks and inconsistency management

* fix lint

* Node local status more info  (#2288)

* wip

* added blockchain status support
fix typos

* address raymond feedback

* improve ux

* Your blockchain

* Validator Manager SDK (#2297)

* validator manager sdk

* fix lint

* fix lint

* remove duplicate code

* fix description

* update test

* complete test

* lint

* lint

* lint

* lint

* lint

* increase health timeout after network restart (#2299)

* increase health timeout after network restart

* fix unit tests

* fix keys e2e

* nits

* nit

* nit

* fix e2e

* use latest relayer dep (#2315)

* Use network name instead of cluster name on sidecar (#2303)

* use network instead of cluster

* replace clustername with network

* update test

* fix test

* fix test

* fix lint

* fix lint

* fix test

* fix lint

* fix test

* fix lint

* address comments

* fix lint

* address comments

* fix lint

* fix conflict

* fix lint

* fuji local clusters (#2309)

* fix contexts and signals

* add fuji cluster

* lint

* point to anr main

* address PR comments

* remove unused function

* address PR comments

* add flags for partial sync to local and remote

* fix panic

* fix e2e

* Update tag (#2332)

* update tag

* update relayer

* update tag

* fixes

---------

Signed-off-by: sukantoraymond <[email protected]>
Co-authored-by: Felipe Madero <[email protected]>

* make network start to create a new network without boostrap snapshot

* add flags struct to network start and stop

* just start network if --local, not use local deployer

* add upgrade to local network

* added aliases on track

* no op

* no op

* Update e2e avago (#2342)

* use avago 1.11.13 to support evm 0.6.12

* fix avago dep

* lint

* use anr main

* Acp 77 PoS using sdk/validatorManager (#2308)

* mv changes frrom pos

* move from pos branch

* mocks

* sync with latest pos/ refactor PoS to sdk approach

* wip

* fix lint. get rid of example in var names, fix sdk<->pkg for validatormanager to make it DRY

* fix err in sdk

* PoS default values

* use sidecar for pos detection with force flag

* rename sc validatorManager

* use proxy for poa

* bugfixes and improve add validator for pos

* proper errors from validator manager smart contract

* rename cmd input

* add PoS e2e
add support for proxy Contract for PoA

* fix lint

* e2e fix arg

* fix typo and non needed check

* rm unneeded check

* fix lint

* fixes for the flow PoS vs PoA

* fix pos sidecar case

* refactor add validator add cmd params for inputs

* adjust e2e params

* use test-defaults for e2e POS

* fix bug. disable validator removal for now

* fix e2e

* address Raymond feedback

* add default value for delegation fee

* use stake-period for PoS

* read balance

* force uint64

* 100s

* add validatorManagerSettings to sdk

* provide default params for PoS and move networkBalance to utils

* add prompt verification for token amount input

* fix PromptChain. not sure how it was included into this PR and where this change is coming from

* address latest feedback

* lint

* improve user output

* Acp77 PoS Validator removal without proof of uptime  (#2338)

* add pos validator removal
debug

* continue debugging pos validator removal

* r4r

* lint

* fix e2e Error: failure initializing validator removal: min stake duration not passed (tx failed to be submitted)

* wait 90sec for min validation period

* min stake duration is 100

* update sidecar after bootstrap validator removed

* disable e2e for removing PoS bootstrap validator

* use 100s

* remove pos non bootstrap validator e2e

* add validator and remove it

* use 60s staking period

* go back to 90 and 120s

* small refactor

* fix duration prompt

* use minimum 100s

* add prompt check for minimum validator staking timr

* fix etna duration input

* use etna for name

* add debug info

* rm debug
force validator removal for PoS

* no need to updatePchainHeight

---------

Signed-off-by: arturrez <[email protected]>

* fix PosManager init

* use clusterNameFlagValue

* rm debug

* remove incorrect available balance

* fix lint

* update avalanchego

* update merge

* lint

* update merge

* fix lint

* update acp 77

---------

Signed-off-by: arturrez <[email protected]>
Co-authored-by: Raymond Sukanto <[email protected]>

* e2e - disable PoS non-bootstrap validator removal

* nosov working

* add mainnet check (#2346)

* disable change owner for sov (#2347)

* teleporter almost working for local

* teleporter deploy working for local

* move relayer to other place

* add flags to relayer deploy command so can be executed without prompts

* intergated relayer deploy for local network

* Use v1.12.0 fuji on e2e (#2344)

* use avago v1.12.0-fuji on etna e2e

* update avalanchego

---------

Co-authored-by: Raymond Sukanto <[email protected]>

* fix root dir

* Acp7 change owner single prompt (#2350)

* reuse prompted addr as a change owner address for blockchain deploy

* mv code closer to SoV

* consistent address display to user

* we should not return err as we will ask in separate prompt later in the flow if provided key didn't work

* Acp77 init validator manager (#2349)

* replace initPoAValidatormanager and initPoSValidatorManager with single initValidatorManager cmd

* lint

* add validators

* remove flag (#2345)

* fixed validators issue

* lint

* remove single node settings

* reenabling teleporter

* Fix local status (#2353)

* fix l1 status for node local

* add e2e for node local cluster status

* add node local status for PoA

* add sleep and fix regex

* missed regex change

* add e2e for status

* simplify regex

* nit

* if only blockchain id is given for genesis key search, provide
the managed key with max balance

* use a given relayer binary

* filter network options to deployed networks

* Revert "filter network options to deployed networks"

This reverts commit 4978276.

* add prompt to decide if install relayer

* final fixes

* lint

* Fix acp77 e2e (#2358)

* fix pattern

* nit

* fix parts of e2e

* add the snapshots again to not brack backward compat

* fix network e2e + persist avago + relayer path

* start doing some merge stuff

* nit

* clean up some e2e to merge

* nits

* lint

* fix unit tests

* fixing packageman for SOV

* fix tracked subnets when deploying multiple blockchains

* add missing file

* add update of blockchain deploy

* nit

* nit

* working again

* fix per node chain config case

* fix some e2e

* supossely public e2e is ok

* nit

* disable teleporter on etna

* make local network to work with relayer 1.5.1

* add subnet evm config for non debug, and set db to leveldb

* reduce local network disk usage from avago logs

* use pre relases on local network by default

* lint

* use also pre release on network start

* add missing file

* deploy relayer for local machine

* do not deploy relayer if fuji

* fix rpc checks for localnet

* avoid using same relayer port for local, etna, fuji

* fix lint

* lint

* fail for nice error for incompatible snapshot

* address PR comments

* fix unit tests

---------

Signed-off-by: sukantoraymond <[email protected]>
Signed-off-by: felipemadero <[email protected]>
Signed-off-by: arturrez <[email protected]>
Co-authored-by: Raymond Sukanto <[email protected]>
Co-authored-by: Michael Kaplan <[email protected]>
Co-authored-by: arturrez <[email protected]>
Co-authored-by: Meaghan FitzGerald <[email protected]>
Co-authored-by: Artur Reznikov <[email protected]>

cmd/blockchaincmd/create.go

@@ -423,13 +423,23 @@ func createBlockchainConfig(cmd *cobra.Command, args []string) error {
 	// covers both subnet-evm vms and custom vms
 	if hasSubnetEVMGenesis, _, err := app.HasSubnetEVMGenesis(blockchainName); err != nil {
 		return err
-	} else if hasSubnetEVMGenesis && createFlags.enableDebugging {
-		if err := SetBlockchainConf(
-			blockchainName,
-			vm.EvmDebugConfig,
-			constants.ChainConfigFileName,
-		); err != nil {
-			return err
+	} else if hasSubnetEVMGenesis {
+		if createFlags.enableDebugging {
+			if err := SetBlockchainConf(
+				blockchainName,
+				vm.EvmDebugConfig,
+				constants.ChainConfigFileName,
+			); err != nil {
+				return err
+			}
+		} else {
+			if err := SetBlockchainConf(
+				blockchainName,
+				vm.EvmNonDebugConfig,
+				constants.ChainConfigFileName,
+			); err != nil {
+				return err
+			}
 		}
 	}