ACP 77 #2140
Merged
ACP 77 #2140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukantoraymond
requested review from
arturrez
and removed request for
a team
|
🔥 Just one high level comment: All L1s will still use Avalanche (technically Snowman++ consensus) for now. PoS vs PoA is just the mechanism for determining how validators are added/removed (ie. sybil resistance). Could we make that clear here by having the prompts ask for the "validator manager" type, rather than the "consensus" type? |
Will clarify the prompt |
Yup this will be the PR for all acp 77 pr to be merged into, will not be merged until acp 77 implementation is released in avalanchego |
* prompt addresses * fix lint * fix lint * fix lint * fix lint * add flags * address comments * fix test * address comments * fix lint --------- Signed-off-by: sukantoraymond <[email protected]>
* prompt addresses * fix lint * fix lint * fix lint * fix lint * add flags * validator prompt * bootstrap validators * add mock * fix lint * update prompt validator * update prompt validator * implement prompts * fix prompt mock * update sidecar * update prompts * update prompts * refactor * update prompts * update prompts * use default balance and weight * generate new node ids and bls * fix lint * add flags * add flags * address comments * address comments * address comments * move validator prompt to deploy * address comments * address comments * fix lint * address comments * address comments * fix test * address comments * fix lint * address coments * address coments * fix test * fix test * fix test * fix lint --------- Signed-off-by: sukantoraymond <[email protected]>
* adding teleporter contract to genesis * fixes for icm on genesis * add icm from a given embedded file * add function to deploy ICM registry * creating mapping values * add consts * make local deploy to work * do not print info for icm support addrs * nit * nit * fix wiz stuff * address PR comments * filter based on balance * add unit tests * Update cmd/blockchaincmd/describe.go Co-authored-by: Michael Kaplan <[email protected]> Signed-off-by: felipemadero <[email protected]> * lint --------- Signed-off-by: felipemadero <[email protected]> Co-authored-by: Michael Kaplan <[email protected]>
* prompt addresses * fix lint * fix lint * fix lint * fix lint * add flags * adding teleporter contract to genesis * validator prompt * bootstrap validators * add mock * fix lint * update prompt validator * update prompt validator * fixes for icm on genesis * add icm from a given embedded file * add function to deploy ICM registry * creating mapping values * add consts * make local deploy to work * do not print info for icm support addrs * nit * implement prompts * fix prompt mock * update sidecar * update prompts * update prompts * refactor * nit * update prompts * fix wiz stuff * update prompts * use default balance and weight * generate new node ids and bls * fix lint * add flags * add flags * add a function to initialize PoA manager * add lib folder * address comments * address comments * address comments * move validator prompt to deploy * address comments * address comments * fix lint * address comments * address comments * fix test * address PR comments * basic PoA manager setting * lint * address comments * fix lint * fix e2e * fix merge * fix merge * filter based on balance * add unit tests * nit * address PR comments * Update cmd/blockchaincmd/describe.go Co-authored-by: Michael Kaplan <[email protected]> Signed-off-by: felipemadero <[email protected]> * nit * address PR comments * lint --------- Signed-off-by: sukantoraymond <[email protected]> Signed-off-by: felipemadero <[email protected]> Co-authored-by: Raymond Sukanto <[email protected]> Co-authored-by: Michael Kaplan <[email protected]>
* wip * go mod tidy * use awm-relayer@main * fixes * use latest awm-relayer pkg which caused upgrade on coreth and avago - has to be resolved * use latest anr and rm prometheus metrics * check for errors * lint * mv to sdk/interchain * some refactoring and added unittests * fix license * fix unittest for now * fix lint * allow empty subnetID add usage working example * rm error msg from example * refactor to address felipe feedback * we should remove this from the test in favour of https://github.com/ava-labs/awm-relayer/blob/main/signature-aggregator/aggregator/aggregator_test.go - we just use exposed API * update readme example * rm goconst fix CI * put `- goconst` back * resolve conficts --------- Co-authored-by: Raymond Sukanto <[email protected]>
* use latest anr main * tidy * bump e2e avago version to be dynamic fee compatible * fix e2e for dynamic fees * lint
* fix contexts and signals * add fuji cluster * lint * point to anr main * address PR comments * remove unused function * address PR comments * add flags for partial sync to local and remote * fix panic * fix e2e
* update tag * update relayer * update tag * fixes --------- Signed-off-by: sukantoraymond <[email protected]> Co-authored-by: Felipe Madero <[email protected]>
* use avago 1.11.13 to support evm 0.6.12 * fix avago dep * lint * use anr main
* mv changes frrom pos * move from pos branch * mocks * sync with latest pos/ refactor PoS to sdk approach * wip * fix lint. get rid of example in var names, fix sdk<->pkg for validatormanager to make it DRY * fix err in sdk * PoS default values * use sidecar for pos detection with force flag * rename sc validatorManager * use proxy for poa * bugfixes and improve add validator for pos * proper errors from validator manager smart contract * rename cmd input * add PoS e2e add support for proxy Contract for PoA * fix lint * e2e fix arg * fix typo and non needed check * rm unneeded check * fix lint * fixes for the flow PoS vs PoA * fix pos sidecar case * refactor add validator add cmd params for inputs * adjust e2e params * use test-defaults for e2e POS * fix bug. disable validator removal for now * fix e2e * address Raymond feedback * add default value for delegation fee * use stake-period for PoS * read balance * force uint64 * 100s * add validatorManagerSettings to sdk * provide default params for PoS and move networkBalance to utils * add prompt verification for token amount input * fix PromptChain. not sure how it was included into this PR and where this change is coming from * address latest feedback * lint * improve user output * Acp77 PoS Validator removal without proof of uptime (#2338) * add pos validator removal debug * continue debugging pos validator removal * r4r * lint * fix e2e Error: failure initializing validator removal: min stake duration not passed (tx failed to be submitted) * wait 90sec for min validation period * min stake duration is 100 * update sidecar after bootstrap validator removed * disable e2e for removing PoS bootstrap validator * use 100s * remove pos non bootstrap validator e2e * add validator and remove it * use 60s staking period * go back to 90 and 120s * small refactor * fix duration prompt * use minimum 100s * add prompt check for minimum validator staking timr * fix etna duration input * use etna for name * add debug info * rm debug force validator removal for PoS * no need to updatePchainHeight --------- Signed-off-by: arturrez <[email protected]> * fix PosManager init * use clusterNameFlagValue * rm debug * remove incorrect available balance * fix lint * update avalanchego * update merge * lint * update merge * fix lint * update acp 77 --------- Signed-off-by: arturrez <[email protected]> Co-authored-by: Raymond Sukanto <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
* use avago v1.12.0-fuji on etna e2e * update avalanchego --------- Co-authored-by: Raymond Sukanto <[email protected]>
* reuse prompted addr as a change owner address for blockchain deploy * mv code closer to SoV * consistent address display to user * we should not return err as we will ask in separate prompt later in the flow if provided key didn't work
* replace initPoAValidatormanager and initPoSValidatorManager with single initValidatorManager cmd * lint
* fix l1 status for node local * add e2e for node local cluster status * add node local status for PoA * add sleep and fix regex * missed regex change * add e2e for status * simplify regex
This reverts commit 4978276.
* fix pattern * nit
* filter network * address comments * fix case * allow cluster in flags * allow cluster in flags --------- Co-authored-by: arturrez <[email protected]>
* dont force users to add local build * remove avalanche go binary in test * update test * fix lint * update test * update node create * update node create * update node create * update node create * update pos test * custom endponit etna (#2354) * update test * address comments * undo avalanche go dir change * fix lint
sukantoraymond
removed
the
DO NOT MERGE
arturrez
approved these changes
Nov 22, 2024
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base PR for all ACP 77 related PRs to be merged into