-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix awm relayer crash for wiz #2191
Conversation
localRelayerSetupTime = 2 * time.Second | ||
localRelayerCheckPoolTime = 100 * time.Millisecond | ||
localRelayerCheckTimeout = 3 * time.Second | ||
AWMRElayerDBWriteIntervalSeconds = 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like capitalization typo here.
Also, do these new consts need to be exported?
@@ -1,7 +1,8 @@ | |||
module github.com/ava-labs/avalanche-cli | |||
|
|||
go 1.21.12 | |||
toolchain go1.22.5 | |||
go 1.22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if updating the golang version here was intentional or not. It is probably best left for it's own PR in case there is any unexpected behavior from updating.
We should also specify the full patch version as whatever the latest 1.22 release is when we do 👍
@@ -356,11 +358,13 @@ func CreateBaseRelayerConfig( | |||
BaseURL: network.Endpoint, | |||
QueryParams: map[string]string{}, | |||
}, | |||
DBWriteIntervalSeconds: AWMRElayerDBWriteIntervalSeconds, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think we'll need to fix these lint errors here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not understanding. I just created a devnet from main branch, and there is no relayer panic. also, relayer on local networks doesn't panic which current conf. am I missing something?
closing as not needed |
Why this should be merged
fixed container crash for awm-relayer
fixes crashes
and
How this works
adds configuration required as default values causes app crash
How this was tested
How is this documented