Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcode icm version #2448

Merged
merged 2 commits into from
Dec 14, 2024
Merged

Hardcode icm version #2448

merged 2 commits into from
Dec 14, 2024

Conversation

felipemadero
Copy link
Collaborator

@felipemadero felipemadero commented Dec 14, 2024

Why this should be merged

blockchain create is not working because latest release of icm-contracts has unexpected version format

How this works

It hardcodes needed icm version v1.0.0 instead of downloading latest release

How this was tested

How is this documented

@felipemadero felipemadero requested a review from a team as a code owner December 14, 2024 13:16
Copy link
Collaborator

@michaelkaplan13 michaelkaplan13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fine as a temporary fix, but we should evaluate how to define dependency versions in a more standardized and robust way going forward.

@felipemadero felipemadero merged commit d887463 into main Dec 14, 2024
35 of 37 checks passed
@felipemadero felipemadero deleted the hardcode-icm-version branch December 14, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants