Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[antithesis] Enable image build for multi-module repos #3342

Closed
wants to merge 2 commits into from

Conversation

marun
Copy link
Contributor

@marun marun commented Aug 28, 2024

Why this should be merged

The proposed subnet-evm refactor requires that construction of the builder image support providing the path to the go module whose dependencies will be downloaded.

How this works

  • Update build_antithesis_builder_image helper to optionally accept the path to a non-root go module
  • Download dependencies for that go module

How this was tested

CI on this PR and the related subnet-evm PR (ava-labs/subnet-evm#1314)

The proposed subnet-evm refactor requires that construction of the
builder image support providing the path to the go module whose
dependencies will be downloaded.
@marun marun self-assigned this Aug 28, 2024
@marun marun added the testing This primarily focuses on testing label Aug 28, 2024
@marun marun marked this pull request as ready for review August 28, 2024 02:14
@marun marun marked this pull request as draft August 28, 2024 03:34
@marun marun closed this Aug 28, 2024
@marun marun deleted the antithesis-module-path branch October 4, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing This primarily focuses on testing
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant