-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[antithesis] Enable reuse of banff e2e test for antithesis testing #3554
Draft
marun
wants to merge
7
commits into
master
Choose a base branch
from
e2e-reuse
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+502
−189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
changed the title
bE2e reuse
[antithesis] Enable reuse of banff e2e test for antithesis testing
Nov 19, 2024
Switched to draft in light of wanting to rebase on #3557 |
marun
force-pushed
the
testing-switch-to-zap
branch
from
November 21, 2024 19:27
cf8a4d4
to
292016a
Compare
Moving to draft and adding a bunch of TODOs prompted by a manually-triggered antithesis run. The error handling of the e2e test is not sufficiently robust, so there are a lot of unhelpful errors that need to be addressed before this PR will be mergeable. |
marun
force-pushed
the
e2e-reuse
branch
2 times, most recently
from
December 11, 2024 16:00
2dbfdce
to
6e0b41c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Having to duplicate existing test coverage to benefit from execution with antithesis is not ideal. Better to be able to trivially refactor compatible e2e coverage for reuse. This PR refactors the banff e2e test for reuse with antithesis to demonstrate that this is possible.
How this works
APITestFunction
type that a compatible e2e test can implement to allow for execution with both ginkgo and antithesisExecuteAPITest
helper to simplify execution of anAPITestFunction
with ginkgoAPITestFunction
executed byExecuteAPITest
How this was tested
CI
TODO
Ensure banff test is actually compatible with the funding provided by the antithesis workload
Ensure antithesis-specific test abort if shared memory is not found (indicating node restart)
Need to be documented in RELEASES.md?
N/A