Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CP-9556: Use correct gas limit for swap #2124

Merged
merged 1 commit into from
Nov 25, 2024
Merged

CP-9556: Use correct gas limit for swap #2124

merged 1 commit into from
Nov 25, 2024

Conversation

atn4z7
Copy link
Collaborator

@atn4z7 atn4z7 commented Nov 25, 2024 •
edited
Loading

Description

Ticket: CP-9556

We were using string instead of number/bigint for txBuildData.gas so we would get something like 0x181883 instead of 0x2c67b

Screenshots/Videos

Testing

Please make sure swapping still works

Checklist

Please check all that apply (if applicable)

  • I have performed a self-review of my code
  • I have verified the code works
  • I have added/updated necessary unit tests
  • I have updated the documentation

@atn4z7 atn4z7 merged commit d1f7f7f into main Nov 25, 2024
4 checks passed
@atn4z7 atn4z7 deleted the cp-9556 branch November 25, 2024 15:23
atn4z7 added a commit that referenced this pull request Nov 25, 2024
@atn4z7
CP-9556: Use correct gas limit for swap (#2124)
be0ba51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onghwan onghwan onghwan approved these changes

@neven-s neven-s Awaiting requested review from neven-s neven-s is a code owner

@ruijialin-avalabs ruijialin-avalabs Awaiting requested review from ruijialin-avalabs ruijialin-avalabs is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atn4z7 @onghwan