Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP-9566 Notifications doesn't make sound when app in background #2126

Merged
merged 8 commits into from
Dec 3, 2024

Conversation

neven-s
Copy link
Collaborator

@neven-s neven-s commented Nov 25, 2024

Description

Ticket: CP-9566

This fixes issue where notifications won't play custom sound when app is in background.
However, Android requires more development since it requires more created chanels and more logic handling notification permissions.

Android

Event Foreground Background
BALANCES_SPENT send sound
no-notification
receive sound
notification
✅ ❌ (double notifications)
BALANCES_RECEIVED receive sound
notification ✅
receive sound
notification ❌ (double notifications)
ALLOWANCE_APPROVED receive sound
notification
receive sound
notification
✅ ❌ (double notifications)

iOS

Event Foreground Background
BALANCES_SPENT send sound
no-notification
send sound
notification
BALANCES_RECEIVED receive sound
notification
receive sound
notification
ALLOWANCE_APPROVED default sound
notification
default sound
notification ✅

Testing

  • make sure you can hear notification sound from any other app
  • unlock wallet and make sure you are receiving notifications
  • put app to background
  • send funds to that wallet
  • observe

Checklist

Please check all that apply (if applicable)

  • I have performed a self-review of my code
  • I have verified the code works
  • I have added/updated necessary unit tests
  • I have updated the documentation

Sorry, something went wrong.

@neven-s neven-s marked this pull request as ready for review December 2, 2024 20:08
Copy link
Collaborator

@atn4z7 atn4z7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@neven-s neven-s merged commit 2bb681f into main Dec 3, 2024
4 checks passed
@neven-s neven-s deleted the notifications-sound branch December 3, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants