Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA - fix smoke test regression #2128

Merged
merged 1 commit into from
Nov 26, 2024
Merged

QA - fix smoke test regression #2128

merged 1 commit into from
Nov 26, 2024

Conversation

eunjisong
Copy link
Contributor

@eunjisong eunjisong commented Nov 25, 2024 •
edited
Loading

Description

  • handle flaky webView testing
    1. connecting core.app
    2. sync issue when adding new account
  • Tested both iOS and Android

Checklist

Please check all that apply (if applicable)

  • I have performed a self-review of my code
  • I have verified the code works
  • I have added/updated necessary unit tests
  • I have updated the documentation

@eunjisong eunjisong marked this pull request as ready for review November 25, 2024 21:49
@eunjisong eunjisong merged commit 389ce0b into main Nov 26, 2024
4 checks passed
@eunjisong eunjisong deleted the qa/fix-1126 branch November 26, 2024 18:36
atn4z7 pushed a commit that referenced this pull request Nov 27, 2024
@eunjisong @atn4z7
QA - fix smoke test regression (#2128)
057fdbe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atn4z7 atn4z7 atn4z7 approved these changes

@Any2suited66 Any2suited66 Awaiting requested review from Any2suited66 Any2suited66 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eunjisong @atn4z7