CP-9399: K2 Alert #2129
Merged
CP-9399: K2 Alert #2129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onghwan
requested review from
neven-s,
atn4z7 and
ruijialin-avalabs
as code owners
onghwan
commented
Nov 25, 2024
There was a problem hiding this comment.
This file is no longer used.
onghwan
commented
Nov 25, 2024
| @@ -65,7 +65,7 @@ | |||
| "@react-native-firebase/messaging": "21.0.0", | |||
| "@react-native-google-signin/google-signin": "13.1.0", | |||
| "@react-native-menu/menu": "1.1.3", | |||
| "@react-navigation/bottom-tabs": "6.6.1", | |||
There was a problem hiding this comment.
I had to downgrade this to match the version used in expo-router. If we don't, it raises an error when this package is used.
atn4z7
reviewed
Dec 2, 2024
| visible, | ||
| title, | ||
| description, | ||
| verticalButtons, |
There was a problem hiding this comment.
how does it look with verticalButtons?
There was a problem hiding this comment.
- verticalButtons: false
- verticalButtons: true
verticalButtons:true will be useful when alert has more than two buttons.
atn4z7
reviewed
Dec 2, 2024
atn4z7
reviewed
Dec 2, 2024
Comment on lines
+77
to
+78
| shouldDisable: (values: Record<string, string>) => { | ||
| return values.delete !== DELETE_TEXT |
atn4z7
reviewed
Dec 2, 2024
atn4z7
reviewed
Dec 2, 2024
atn4z7
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket: CP-9399
showAlert()function for simple alertsAlertWithTextInputscomponent for the alerts with text inputs.Screenshots/Videos