CP-9586 Unable to start staking #2132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neven-s
requested review from
atn4z7,
ruijialin-avalabs and
onghwan
as code owners
atn4z7
reviewed
Nov 26, 2024
| @@ -99,7 +99,7 @@ export default function StakingAmount(): JSX.Element { | |||
| percent: (100 / factor).toString() | |||
| }) | |||
| if (!cumulativeBalance) return | |||
| setInputAmount(cumulativeBalance.div(factor)) | |||
| setInputAmount(zeroAvaxPChain().add(cumulativeBalance.div(factor))) | |||
There was a problem hiding this comment.
just curious, what issue did you run into here?
atn4z7
added a commit
that referenced
this pull request
Nov 27, 2024
Co-authored-by: An Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket: CP-9586
This PR fixes couple wrong conversions of TokenUnit to appropriate subunit.
Also renamed quite few params and converted to bigint so we avoid these mistakes in future
Testing
Checklist
Please check all that apply (if applicable)