Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

params: fix log + errors for Cancun timestamp #368

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Conversation

darioush
Copy link
Collaborator

Why this should be merged

  • Fixes typos resulting in incorrectly displayed Cancun time in chain info text.
  • Fixes returned error in case of Cancun timestamp compatibility to refer to the Cancun timestamp

How this works

Fixes typos

How this was tested

CI

@darioush darioush marked this pull request as ready for review October 31, 2023 17:23
params/config.go Outdated Show resolved Hide resolved
Co-authored-by: aaronbuchwald <[email protected]>
Signed-off-by: Darioush Jalali <[email protected]>
@darioush darioush requested a review from anusha-ctrl November 2, 2023 16:20
@darioush darioush merged commit 3867e0f into master Nov 3, 2023
@darioush darioush deleted the fix-cancun-times branch November 3, 2023 20:48
joshua-kim added a commit that referenced this pull request Nov 6, 2023
commit 740c60e
Author: Anusha <[email protected]>
Date:   Fri Nov 3 14:30:36 2023 -0700

    remove extra err check (#378)

commit 3867e0f
Author: Darioush Jalali <[email protected]>
Date:   Fri Nov 3 13:48:10 2023 -0700

    params: fix log + errors for Cancun timestamp (#368)

    Co-authored-by: aaronbuchwald <[email protected]>

commit a3726f1
Author: aaronbuchwald <[email protected]>
Date:   Fri Nov 3 12:04:45 2023 -0400

    Start v0.12.8 release (#374)

Signed-off-by: Joshua Kim <[email protected]>
joshua-kim added a commit that referenced this pull request Nov 21, 2023
commit c609216
Author: Ceyhun Onur <[email protected]>
Date:   Fri Nov 17 17:48:21 2023 +0300

    add context to network handlers (#383)

commit c97fe2f
Author: aaronbuchwald <[email protected]>
Date:   Fri Nov 17 04:42:41 2023 -0500

    Update acceptor tip before sending chain events to subscribers (#392)

commit 7a3d26b
Author: Joshua Kim <[email protected]>
Date:   Wed Nov 15 17:30:52 2023 -0500

    Add loggers to SDK Handlers (#373)

commit 7cefd0f
Author: Ceyhun Onur <[email protected]>
Date:   Mon Nov 13 23:40:37 2023 +0300

    remove specific folders (#385)

commit ce93f8e
Author: xiaolou86 <[email protected]>
Date:   Thu Nov 9 07:52:22 2023 +0800

    docs: fix typo (#380)

commit bf20517
Author: Darioush Jalali <[email protected]>
Date:   Tue Nov 7 11:17:08 2023 -0800

    align rpc/types.go with upstream (#381)

    * ethclient: restore special casing in ToBlockNumArg

    * add explicit SafeBlockNumber

    * wspace

    * add string

commit 740c60e
Author: Anusha <[email protected]>
Date:   Fri Nov 3 14:30:36 2023 -0700

    remove extra err check (#378)

commit 3867e0f
Author: Darioush Jalali <[email protected]>
Date:   Fri Nov 3 13:48:10 2023 -0700

    params: fix log + errors for Cancun timestamp (#368)

    Co-authored-by: aaronbuchwald <[email protected]>

commit a3726f1
Author: aaronbuchwald <[email protected]>
Date:   Fri Nov 3 12:04:45 2023 -0400

    Start v0.12.8 release (#374)

Signed-off-by: Joshua Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants