-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core/state] Prefetch Trie Nodes Concurrently #372
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronbuchwald
previously approved these changes
Nov 20, 2023
darioush
previously approved these changes
Nov 21, 2023
patrick-ogrady
dismissed stale reviews from darioush and aaronbuchwald
via
November 21, 2023 00:15
4fc35d9
darioush
previously approved these changes
Nov 21, 2023
aaronbuchwald
previously approved these changes
Nov 21, 2023
ceyonur
reviewed
Nov 21, 2023
patrick-ogrady
commented
Nov 21, 2023
darioush
approved these changes
Nov 21, 2023
aaronbuchwald
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Context: ethereum/go-ethereum#28266
How this works
This change modifies
core/state/trie_prefetcher.go
to prefetch trie nodes in parallel. In addition to this tweak, prefetching is no longer aborted (wait until all keys on a trie are prefetched) and we now prefetch tries during block building.How this was tested
Open Questions
(-> start with32
seems low given the size of this data, see example below): [core/state] Prefetch Tries Concurrently (Aggressive=48) #37516
Why are there any skipped prefetch tasks?: 947cad8update the base trie to one with the most populated keys from prefetching (approx): [core/state] Return Best Trie Copy #396Limit copies persubfetcher
(could ensure no single trie is copied too many times, while still being less than disk concurrency)?