chore(core/types): Body libevm RLP codec hooks
#760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
force-pushed
the
qdm12/core/types/body-libevm
branch
from
2be5a7b to
87f5043
Compare
qdm12
changed the title
Body libevm RLP codec hooks
qdm12
commented
Jan 21, 2025
| // - withdrawals Withdrawals | ||
| } | ||
|
|
||
| func (b *BodyExtra) EncodeRLP(eth *ethtypes.Body, writer io.Writer) error { |
There was a problem hiding this comment.
Add test for this and DecodeRLP
| @@ -26,3 +29,12 @@ func WithHeaderExtras(h *Header, extra *HeaderExtra) *Header { | |||
| extras.Header.Set(h, extra) | |||
| return h | |||
| } | |||
|
|
|||
| func GetBodyExtra(b *Body) *BodyExtra { | |||
There was a problem hiding this comment.
Add test for this and WithBodyExtra
2 tasks
qdm12
changed the base branch from
libevm-upstream-types
to
qdm12/core/types/header-copy-hooks
qdm12
force-pushed
the
qdm12/core/types/header-copy-hooks
branch
2 times, most recently
from
da83d82 to
58f1171
Compare
qdm12
force-pushed
the
qdm12/core/types/body-libevm
branch
2 times, most recently
from
9978144 to
7027a42
Compare
qdm12
force-pushed
the
qdm12/core/types/body-libevm
branch
from
7027a42 to
53eb228
Compare
qdm12
force-pushed
the
qdm12/core/types/body-libevm
branch
from
53eb228 to
d65a0d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
How this works
Note: this branch is independent but it's based on #759 because the next PR #750 depend on both this PR and #759
How this was tested
Need to be documented?
Need to update RELEASES.md?