-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wrap.Verify interface changes #769
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM - I think it's preferred that we align the signature tests with AvalancheGo upstream as well ie. use canonicalErr
instead of getValidatorSetErr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, please only merge after avalanchego pr has merged
Yes, of course
…On Tue, Jan 28, 2025, 4:18 PM Darioush Jalali ***@***.***> wrote:
***@***.**** approved this pull request.
lgtm, please only merge after avalanchego pr has merged
—
Reply to this email directly, view it on GitHub
<#769 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF2OOH2VO7WC6SGESAK65J32M7XZZAVCNFSM6AAAAABWBARJUOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNZZGQZTGNRSGE>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The merge-base changed after approval.
Why this should be merged
Updated interface changes per ava-labs/avalanchego#3679
How this works
Intuitive.
How this was tested
Existing tests.
Need to be documented?
No
Need to update RELEASES.md?
No