Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wrap.Verify interface changes #769

Merged
merged 10 commits into from
Jan 29, 2025

Conversation

tsachiherman
Copy link
Contributor

Why this should be merged

Updated interface changes per ava-labs/avalanchego#3679

How this works

Intuitive.

How this was tested

Existing tests.

Need to be documented?

No

Need to update RELEASES.md?

No

@tsachiherman tsachiherman requested review from ceyonur, darioush and a team as code owners January 28, 2025 17:30
@tsachiherman tsachiherman changed the title Tsachi/minimize verify interface Update wrap.Verify interface changes Jan 28, 2025
@tsachiherman tsachiherman self-assigned this Jan 28, 2025
aaronbuchwald
aaronbuchwald previously approved these changes Jan 28, 2025
Copy link
Collaborator

@aaronbuchwald aaronbuchwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM - I think it's preferred that we align the signature tests with AvalancheGo upstream as well ie. use canonicalErr instead of getValidatorSetErr

darioush
darioush previously approved these changes Jan 28, 2025
Copy link
Collaborator

@darioush darioush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, please only merge after avalanchego pr has merged

@tsachiherman
Copy link
Contributor Author

tsachiherman commented Jan 28, 2025 via email

aaronbuchwald
aaronbuchwald previously approved these changes Jan 29, 2025
Copy link
Collaborator

@aaronbuchwald aaronbuchwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsachiherman tsachiherman enabled auto-merge (squash) January 29, 2025 16:50
@tsachiherman tsachiherman dismissed aaronbuchwald’s stale review January 29, 2025 17:06

The merge-base changed after approval.

@tsachiherman tsachiherman merged commit 584302d into master Jan 29, 2025
8 checks passed
@tsachiherman tsachiherman deleted the tsachi/minimize-verify-interface branch January 29, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants