Delay block in place #454
Merged
Delay block in place #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinifinity
reviewed
Dec 21, 2023
| @@ -569,7 +570,7 @@ impl DiskBufferRequester { | |||
| .send(BufferCmd::GetPage((space_id, page_id), resp_tx)) | |||
| .map_err(StoreError::Send) | |||
| .ok(); | |||
| resp_rx.blocking_recv().unwrap() | |||
| block_in_place(move || resp_rx.blocking_recv().unwrap()) | |||
There was a problem hiding this comment.
Just guessing that you don't need this here because you're not in an async function
There was a problem hiding this comment.
+1 will it work if not in an async call?
There was a problem hiding this comment.
Without this, all the tests fail. This code does nothing if you're not in an async context. If you are, then it moves you to a blockable thread to prevent interference with the async runtime.
richardpringle
approved these changes
Jan 2, 2024
|
It's safe to call `block_in_place` if we're not in an async runtime, or even to do it recursively. The docs suggest you defer calling it until you know you're about to actually block. This removes the calls from several locations and puts them all in the one blocking call we have -- the one that reads from the cache. This didn't make a big difference, but it does eliminate the extra overhead of moving things over to another thread prematurely. Will attach flamegraphs of 1,000 inserts.
Added a block_in_place to resolve the last test issue
rkuris
force-pushed
the
rkuris/delay-block-in-place
branch
from
82b34ec to
f733f08
Compare
xinifinity
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can delay calling
block_in_placeuntil we actually block. This results in a small performance gain, probably more noticeable when we start doing reads in parallel.Before:
After