Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for start key argument in fwdctl dump command #476

Merged
merged 15 commits into from
Feb 15, 2024
Merged

add support for start key argument in fwdctl dump command #476

merged 15 commits into from
Feb 15, 2024

Conversation

danlaine
Copy link

@danlaine danlaine commented Jan 5, 2024 •
edited
Loading

Adds a new optional START_KEY argument. The START_KEY is not expected to be hex. The string is turned into bytes with .as_bytes(). Tested manually and it works.

@danlaine danlaine added the enhancement New feature or request label Jan 5, 2024
@danlaine danlaine self-assigned this Jan 5, 2024
rkuris
rkuris reviewed Jan 5, 2024
View reviewed changes
rkuris
rkuris reviewed Jan 5, 2024
View reviewed changes
@danlaine danlaine closed this Jan 12, 2024
@danlaine danlaine reopened this Jan 12, 2024
@danlaine danlaine marked this pull request as ready for review February 8, 2024 16:37
@danlaine danlaine changed the title [WIP] add support for start key argument in fwdctl dump command add support for start key argument in fwdctl dump command Feb 8, 2024
@danlaine danlaine requested a review from rkuris February 8, 2024 16:37
rkuris
rkuris requested changes Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@rkuris rkuris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes are fine, but lets not mix the upgrade of clap in with code changes.

@danlaine danlaine force-pushed the fwdctl-dump-start-key branch from 15a9c1b to dc17813 Compare February 8, 2024 17:33
@rkuris rkuris self-requested a review February 8, 2024 19:59
@danlaine danlaine enabled auto-merge (squash) February 12, 2024 23:37
@danlaine danlaine merged commit 7be6471 into main Feb 15, 2024
5 of 6 checks passed
@danlaine danlaine deleted the fwdctl-dump-start-key branch February 15, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkuris rkuris rkuris approved these changes

@richardpringle richardpringle richardpringle approved these changes

@xinifinity xinifinity Awaiting requested review from xinifinity

Assignees

@danlaine danlaine

Labels
enhancement New feature or request
Projects
Platform Engineering Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danlaine @rkuris @richardpringle