Verify chunk signature #1862
Verify chunk signature #1862
Conversation
tsachiherman
requested review from
aaronbuchwald and
joshua-kim
as code owners
…va-labs/hypersdk into tsachi/configurable-chunk-rate-limiter
x/dsmr/block.go
Outdated
| @@ -16,6 +18,8 @@ import ( | |||
|
|
|||
| const InitialChunkSize = 250 * 1024 | |||
|
|
|||
| var ErrFailedSigVerification = errors.New("failed to verify signature") | |||
There was a problem hiding this comment.
Can we make this more detailed ie. at least include the signature type and the type of container the signature was over like "failed to verify bls chunk signature"
x/dsmr/p2p.go
Outdated
| // TODO: | ||
| // check if the expiry of this chunk isn't in the past or too far into the future. | ||
|
|
||
| // TODO: | ||
| // check if the producer was expected to produce this chunk. | ||
|
|
||
| // check to see if this chunk was already accepted. |
There was a problem hiding this comment.
Can these comments be moved into the verifier?
From p2p perspective, it should only need to know that it must verify the chunk in some context, but doesn't need to know what verification takes place.
There was a problem hiding this comment.
Should we add a TODO for rate limiting chunk production from the given producer?
x/dsmr/p2p.go
Outdated
| @@ -127,10 +128,18 @@ func (c ChunkSignatureRequestVerifier[T]) Verify( | |||
| } | |||
| } | |||
|
|
|||
| // verify that the signature is a valid signature over the unsigned chunk. | |||
There was a problem hiding this comment.
Could we remove obvious comments that match the function name ie. parse and verify unless the comment provides additional information?
x/dsmr/p2p.go
Outdated
| @@ -119,6 +119,7 @@ func (c ChunkSignatureRequestVerifier[T]) Verify( | |||
| _ *warp.UnsignedMessage, | |||
| justification []byte, | |||
| ) *common.AppError { | |||
| // parse the chunk | |||
There was a problem hiding this comment.
Can we remove obvious comments that don't add new information?
…va-labs/hypersdk into tsachi/configurable-chunk-rate-limiter
What ?
This PR add verification of the received chunk signature.