Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uptime tracking #1263

Merged
merged 81 commits into from
Nov 13, 2024
Merged

Uptime tracking #1263

merged 81 commits into from
Nov 13, 2024

Conversation

ceyonur
Copy link
Collaborator

@ceyonur ceyonur commented Aug 1, 2024

This PR contains an unfinished work in AvalancheGo and depends on the PR: ava-labs/avalanchego#3404

Why this should be merged

  • Connects uptime tracking modules with VM
  • Starts a new goroutine that fetches current validator set from P-chain to and loads to subnet-evm state
  • GetCurrentValidator APIs.

How this was tested

  • Added UTs
  • Local network testing

How is this documented

  • Not yet

@ceyonur ceyonur changed the base branch from master to pausable-uptime-manager September 16, 2024 20:24
@darioush
Copy link
Collaborator

darioush commented Nov 6, 2024

This LGTM, see this comment/question about the handling of possible duplicate nodeIDs between the staker set and SoVs ava-labs/avalanchego#3404 (comment)

darioush
darioush previously approved these changes Nov 6, 2024
darioush
darioush previously approved these changes Nov 6, 2024
darioush
darioush previously approved these changes Nov 8, 2024
plugin/evm/validators/state.go Show resolved Hide resolved
plugin/evm/uptime/pausable_manager.go Outdated Show resolved Hide resolved
darioush
darioush previously approved these changes Nov 8, 2024
plugin/evm/uptime/pausable_manager_test.go Outdated Show resolved Hide resolved
plugin/evm/validators/state.go Outdated Show resolved Hide resolved
@ceyonur ceyonur mentioned this pull request Nov 13, 2024
2 tasks
@ceyonur ceyonur merged commit 981830e into master Nov 13, 2024
14 checks passed
@ceyonur ceyonur deleted the uptime-tracking branch November 13, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants