Release 2.4.1 - Tranport field issue resolved

avadev · Nov 4, 2022 · 3e337b6 · 3e337b6
1 parent d3a51b0
commit 3e337b6
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 16 deletions.
diff --git a/Framework/AppInterface.php b/Framework/AppInterface.php
@@ -20,7 +20,7 @@ interface AppInterface
     /**
      * Connector version
      */
-    const APP_VERSION = '2.4.0';
+    const APP_VERSION = '2.4.1';
 	/**
      * Avalara APP String
      */

diff --git a/Framework/Interaction/Rest/Definitions.php b/Framework/Interaction/Rest/Definitions.php
@@ -25,7 +25,7 @@
 class Definitions extends \ClassyLlama\AvaTax\Framework\Interaction\Rest
     implements \ClassyLlama\AvaTax\Api\RestDefinitionsInterface
 {
-    const PARAMETERS_FILTER = 'id=621';
+    const PARAMETERS_FILTER = 'name=Transport';
     /**
      * @var RestConfig
      */

diff --git a/Framework/Interaction/Tax.php b/Framework/Interaction/Tax.php
@@ -431,19 +431,22 @@ protected function convertTaxQuoteDetailsToRequest(
         $storeId = $quote->getStoreId();
         $serialized_transport = $this->config->getVATTransport($storeId);
         $shipping_method = $quote->getShippingAddress()->getShippingMethod();
-        $config_transports = $this->serialize->unserialize($serialized_transport);
         $transport_parameters_value = $this->config::AVATAX_PARAMETERS_TRANSPORT_DEFAULT_VALUE;
-        if($config_transports && !empty($config_transports))
-        {
-            foreach($config_transports as $config_transport)
-            {
-                if($shipping_method == $config_transport['transport_shipping'])
-                {
-                    $transport_parameters_value = $config_transport['transport'];
-                    break;
-                }                    
-            }
-        }
+		if($serialized_transport && !empty($serialized_transport))
+		{
+			$config_transports = $this->serialize->unserialize($serialized_transport);
+			if($config_transports && !empty($config_transports))
+			{
+				foreach($config_transports as $config_transport)
+				{
+					if($shipping_method == $config_transport['transport_shipping'])
+					{
+						$transport_parameters_value = $config_transport['transport'];
+						break;
+					}                    
+				}
+			}
+		}
         $data = [
             'store_id' => $store->getId(),
             'commit' => false, // quotes should never be committed

diff --git a/composer.json b/composer.json
@@ -1,7 +1,7 @@
 {
     "name": "avalara/avatax-magento",
     "type": "magento2-module",
-    "version": "2.4.0",
+    "version": "2.4.1",
     "license": "OSL-3.0",
     "description": "Magento module for Avalara's AvaTax suite of business tax calculation and processing services. Uses the AvaTax REST v2 API.",
     "require": {

diff --git a/docs/getting-started.md b/docs/getting-started.md
@@ -57,7 +57,7 @@ This is the recommended installation method as it allows you to easily update th
 1. Require the desired version of AvaTax. Latest version can be installed by running following command:
 
    ```
-   composer require avalara/avatax-magento:2.4.0
+   composer require avalara/avatax-magento:2.4.1
    ```
 
 2. Setup the AvaTax module in magento