Adjust release process #3392
Merged
Adjust release process #3392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rulesets prohibit pushing commits on `main` without a PR. This means that running `npm version` within `main` actually creates more work. Further, the release workflow requires CI to have passed on the tagged commit, but it's triggered when the tag is pushed. Simplify by triggering on pushes to `main`, when that commit has a release tag. We can then create a PR for a release branch, push the tag commit, and trigger the release when merging the commit into `main`. This still has to happen locally since we must include the tagged commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rulesets prohibit pushing commits on
mainwithout a PR. This means that runningnpm versionwithinmainactuallycreates more work. Further, the release workflow requires CI to have passed on the tagged commit, but it's triggered
when the tag is pushed.
Simplify by triggering on pushes to
main, when that commit has a release tag. We can then create a PR for a releasebranch, push the tag commit, and trigger the release when merging the commit into
main. This still has to happenlocally since we must include the tagged commit.