Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mark as unwatched button #222

Merged
merged 1 commit into from
May 6, 2024
Merged

Add mark as unwatched button #222

merged 1 commit into from
May 6, 2024

Conversation

dnicolson
Copy link
Contributor

Description

Briefly playing a video can often result in the whole video being marked as watched. Adding this button is a convenient way to prevent actual unwatched videos from being removed when removing all watched videos.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Closing issues

Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

@dnicolson
Copy link
Contributor Author

Hi @avallete, can you please take a look at this?

@avallete
Copy link
Owner

avallete commented May 6, 2024

Yeah I think that's an issue with youtube itself. It usually happen if you start a video, then go toward the end without watching anything. Note that the opposite can also happen if you got to the beginning of an already watched video.

Anyways, this change LGTM, but could you provide some screenshot of what it'll look like in the UI ?

@dnicolson
Copy link
Contributor Author

PixelSnap 2024-05-06 at 18 57 55@2x
PixelSnap 2024-05-06 at 18 58 07@2x

@avallete avallete merged commit 1ca7250 into avallete:master May 6, 2024
1 check passed
@avallete
Copy link
Owner

avallete commented May 6, 2024

PixelSnap 2024-05-06 at 18 57 55@2x
PixelSnap 2024-05-06 at 18 58 07@2x

Thanks for contributing !

avallete pushed a commit that referenced this pull request May 6, 2024
# [1.7.0](v1.6.2...v1.7.0) (2024-05-06)

### Bug Fixes

* slider truncation ([#223](#223)) ([227640b](227640b))

### Features

* add mark as unwatched button ([#222](#222)) ([1ca7250](1ca7250))
@avallete
Copy link
Owner

avallete commented May 6, 2024

🎉 This PR is included in version 1.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants