-
Notifications
You must be signed in to change notification settings - Fork 51
Upgrade to Blacklight 8 #6316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Upgrade to Blacklight 8 #6316
Conversation
This reverts commit 5977af8.
Since we build/populate the Media Objects page from IIIF rather than Blacklight results, should we remove the section from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This component is for the publish/unpublish actions on the bookmarks page. They do not require generating a modal or other confirmation so we add method: post
to the link creation so the action is automatically performed when the button is clicked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This component copies the regular DocumentComponent in order to rearrange how entries display information on the index page. The biggest difference is that the thumbnail is the last thing in the default blacklight 8, whereas we have the thumbnail included as the second item.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This adds our expected styling classes to the media object title field on the index page. It is possible that this is logic that could be passed in from the config or by overriding the partial that renders the component, but this seemed like the easier/more obvious approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This partial adds the found in:
fields to the metadata display
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to have the found in:
information available to the partial, we need to make sure that the SolrDocument is passed through to the partial. This also adds our specific styling classes to the initialization of the component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This component adds our placeholder image if a thumbnail is not found.
<%= render Blacklight::Document::ActionsComponent.new(document: nil, | ||
tag: 'div', | ||
classes: "#{controller_name}Tools", | ||
link_classes: 'btn btn-outline', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This partial override is specifically to change the classes passed into the initialization of the actions component to match prior Avalon behavior/rendering.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Related issue: #5056