"Fix validation error message displayed prematurely on page load for form submission" #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey thanks for the PR but someone else made similar changes earlier (#39 ). Edit: oh wait i realized this is a different file |
suryabulusu
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes the issue where the validation error message was displayed prematurely on page load for the form submission in the CollegePredictor component.
Key Changes:
Implemented logic to ensure the validation error for the rank input only appears after the user attempts to submit the form. This prevents confusion for users as the error message is no longer shown before any interaction.
Added a state variable submitted to track whether the form has been submitted, which controls when to display the validation error messages for the rank and input fields.
This change enhances the user experience by providing clearer feedback only when appropriate.