Shuffle Question Order in Quiz Assessments/Homeworks #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suryabulusu
reviewed
Jan 30, 2025
| @@ -136,6 +175,7 @@ async def create_session(session: Session): | |||
| current_session["time_remaining"] = last_session.get("time_remaining", None) | |||
| current_session["has_quiz_ended"] = last_session.get("has_quiz_ended", False) | |||
| current_session["metrics"] = last_session.get("metrics", None) | |||
| current_session["question_order"] = last_session["question_order"] | |||
There was a problem hiding this comment.
you sure this shouldn't have a default value here? i'm wondering if it will cause issues. with previously completed quizzes, etc. this necessitates that we add identity order to all existing sessions, right?
suryabulusu
reviewed
Jan 30, 2025
| @@ -70,6 +106,9 @@ async def create_session(session: Session): | |||
| if last_session is None: | |||
| logger.info("No previous session exists for this user-quiz combo") | |||
| current_session["is_first"] = True | |||
| if not session.omr_mode: | |||
| question_order = shuffle_question_order(quiz["question_sets"]) | |||
There was a problem hiding this comment.
why this variable.. just call the function in next line
suryabulusu
reviewed
Jan 30, 2025
| bucket_size = Settings().subset_size | ||
|
|
||
| global_index = 0 # Track global index across all questions | ||
| logger.info(question_sets) |
There was a problem hiding this comment.
why log all questions.
There was a problem hiding this comment.
ohh missed it! will remove this.
suryabulusu
reviewed
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the quiz assessment feature by introducing randomized question shuffling and ensuring accurate response storage under shuffled conditions.
Key Highlights