[IMP] hr_timesheet_usability: En lineas de analitica inicializar los … #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…campos hora inicio y fin, y también empleado.
|
@avanzosc/developers .... review please |
Daniel-CA
approved these changes
Jan 24, 2022
anajuaristi
reviewed
Jan 24, 2022
| employee = employee_obj.search(cond, limit=1) | ||
| return employee if employee else employee_obj | ||
|
|
||
| time_start = fields.Float(default=default_times) |
There was a problem hiding this comment.
time_start y time_stop ya los crea hr_timesheet_activity_begin_end entonces, deberían estar aquí de nuevo? Es porque se les asigna aquí un default que no tienen en el otro lado?
There was a problem hiding this comment.
Muy buenos días @anajuaristi , efectivamente, en el módulo origen los crea, pero no les da ningún valor por defecto, esto hacé que cuando se muestra el formulario o el tree con estos campos, aparezcan vacios.
Con la modificación que yo he hecho al módulo "hr_timesheet_usability" les defino un default para que les de un valor por defecto.
Un saludo.
oihane
requested changes
Feb 9, 2022
|
|
||
| time_start = fields.Float(default=default_times) | ||
| time_stop = fields.Float(default=default_times) | ||
| employee_id = fields.Many2one(default=default_employee_id) |
There was a problem hiding this comment.
En analitica NO SIEMPRE hay que informar el empleado.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…campos hora inicio y fin, y también empleado.