[16.0][IMP] repair_order_type: Add api.depends to api.onchange #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unaiberis
force-pushed
the
16.0-imp-repair_order_type
branch
2 times, most recently
from
4a3b028 to
eb0fe8e
Compare
oihane
force-pushed
the
16.0-imp-repair_order_type
branch
from
eb0fe8e to
14e1e93
Compare
oihane
requested changes
Jul 23, 2024
Comment on lines
+20
to
+29
| @api.depends("repair_id.type_id") | ||
| def _compute_location_id(self): | ||
| res = super()._compute_location_id() | ||
| if self.type == "add": | ||
| self.location_id = self.repair_id.type_id.location_id.id | ||
| self.location_dest_id = self.repair_id.type_id.location_dest_id.id | ||
| else: | ||
| self.location_id = self.repair_id.type_id.location_dest_id.id | ||
| self.location_dest_id = self.repair_id.type_id.location_id.id | ||
| return res |
There was a problem hiding this comment.
No estas teniendo en cuenta que el compute se ejecuta de forma múltiple, y debe de modificarse también en el caso de que se cambie el type
|
@anajuaristi la combinación de módulos repair_type y repair_type_sequence de OCA es prácticamente igual a este modulo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.