fix: Make default project name lowercase, fixes #378

avast · Nov 11, 2022 · f48270d · f48270d
1 parent 960adc4
commit f48270d
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 1 deletion.
diff --git a/src/main/groovy/com/avast/gradle/dockercompose/ComposeSettings.groovy b/src/main/groovy/com/avast/gradle/dockercompose/ComposeSettings.groovy
@@ -101,7 +101,10 @@ abstract class ComposeSettings {
             else {
                 return "${safeProjectNamePrefix}_${nestedName}"
             }
-        })
+        }).map{ String projectName ->
+            // docker-compose project names must be lowercase
+            projectName.toLowerCase()
+        }
 
         useComposeFiles.empty()
         startedServices.empty()

diff --git a/src/test/groovy/com/avast/gradle/dockercompose/DockerComposePluginTest.groovy b/src/test/groovy/com/avast/gradle/dockercompose/DockerComposePluginTest.groovy
@@ -81,6 +81,32 @@ class DockerComposePluginTest extends Specification {
         up.composeExecutor.get().parameters.useComposeFiles.get() == ['test.yml']
     }
 
+    def "project name should always be lowercase"() {
+        def project = ProjectBuilder.builder().build()
+        when:
+        project.plugins.apply 'docker-compose'
+        project.dockerCompose {
+            nestedUppercaseTask {
+                useComposeFiles = ['docker-compose.yml']
+            }
+			nestedUppercaseProjectName {
+                projectNamePrefix = "UPPERCASE"
+			}
+            nestedUppercaseProjectNamePrefix {
+                projectNamePrefix = "UPPERCASE"
+            }
+        }
+
+        then:
+
+		['nestedUppercaseTask', 'nestedUppercaseProjectName'].forEach{ String config ->
+			def projectName = project.dockerCompose."$config".projectName.get()
+			assert projectName.toLowerCase() == projectName
+		}
+
+
+    }
+
     def "is possible to access servicesInfos of nested setting"() {
         def project = ProjectBuilder.builder().build()
         when: