Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "invalid reference format" error if nested name is not set #461

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Fix "invalid reference format" error if nested name is not set #461

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df91156
Fix "invalid reference format" error by avoiding trailing underscore …
jamesbassett Oct 17, 2024
37bb0eb
Merge branch 'main' into fix_project_name
jamesbassett Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/groovy/com/avast/gradle/dockercompose/ComposeSettings.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,10 @@ abstract class ComposeSettings {
return customProjectName
}
else if (projectNamePrefix) {
return "${projectNamePrefix}_${nestedName}"
return nestedName ? "${projectNamePrefix}_${nestedName}" : projectNamePrefix
}
else {
return "${safeProjectNamePrefix}_${nestedName}"
return nestedName ? "${safeProjectNamePrefix}_${nestedName}" : safeProjectNamePrefix
}
}).map{ String projectName ->
// docker-compose project names must be lowercase
Expand Down